[GitHub] eirikbakke commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation

[GitBox <gi...@apache.org>]

eirikbakke commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation
URL: https://github.com/apache/incubator-netbeans/pull/504#issuecomment-457602967
 
 
   It would be really nice to get this patch integrated. It makes a huge difference. Here's my experience:
   
   After upgrading from NetBeans 8 to NetBeans 9, my multi-module NetBeans platform maven project would constantly need to be recompiled after errors like these:
   * java.lang.ClassFormatError: Duplicate method name&signature in class file
   * ClassFormatError: Absent Code attribute in method that is not native or abstract
   * NoClassDefFoundError: Could not initialize class
   
   I then applied this patch in September, on top of NetBeans 9, and had no more problems with these errors.
   
   When NetBeans 10 was released, I started using it _without_ the patch for two weeks. The errors above started appearing daily again. It was a huge annoyance. I'm have now applied the patch again, and the errors are gone.
   
   (More usage background: I always use Compile-on-Save, and often also Apply Code Changes in the debugger. In my own project, the "start state" is always a clean maven build--but with the patch applied, I can go for several days without needing to do a clean build again. And when I do run a clean build, it's usually because I need to for an unrelated reason.)
   
   > While I continue to find the behavior in this patch preferable on balance to the stock behavior, it is sufficiently controversial that it should just be considered on hold until I can find time to spend on a more ambitious alternate approach.
   
   What is the main "controversial" aspect of this patch? Are there downsides to it?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists