[GitHub] [zeppelin] bhavikpatel9977 edited a comment on issue #3488: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox <gi...@apache.org>]

bhavikpatel9977 edited a comment on issue #3488: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3488#issuecomment-547827387
 
 
   > Thanks. Now, you can validate `shiro.ini` before injecting it into Jetty. I think we could add your logic in side `public static void main` directly. But you might consider the case that `shiro.ini` doesn't exist and isn't needed. And could you please add tests cases?
   
   Yes, we can directly add logic in `public static void main` but I have used injection to avoid updating existing test-cases and I have to write new test class under `configuration` dir, right as it is configuration related validation.
   
   Based on the `shiro.ini` file we are checking the triggering the Authentication Service, so if shiro path exists then only we are validating it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services