You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2021/10/19 11:09:09 UTC
[GitHub] [incubator-pegasus] Smityz opened a new pull request #829: feat: support read throttling by size
Smityz opened a new pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829
to be finished
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740056929
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
+ rpc.error() = dsn::ERR_BUSY;
+ _counter_recent_read_throttling_reject_count->increment();
Review comment:
ref https://github.com/XiaoMi/rdsn/blob/master/src/replica/replica_throttle.cpp#L56
For compatibility, I think it's ok to combine them. We can distinguish `size` and `qps` from other perf_counters easily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740049970
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
Review comment:
Actually, it has nothing to do with any size, it only checks if the token basket is empty. If it's empty, then reject all requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740055761
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
Review comment:
it can be remotely changed if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741584311
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle tests in my next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz merged pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz merged pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741582658
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
Could you add some tests for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740053407
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
Review comment:
You have define the default value in get_token, no need pass the FLAGS_read_throttling_by_size_request_count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740058463
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
Review comment:
You just get current the avaliable token, so which case need change? or why change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741584311
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle controller in my next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740044367
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
+ rpc.error() = dsn::ERR_BUSY;
+ _counter_recent_read_throttling_reject_count->increment();
Review comment:
I suggest the reject counter can be distinct the `size` and `qps`, which we can get the request why exceed the throld
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741584311
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle tests in my next PR
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle controller in my next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741582658
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
Could you add some tests for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741584311
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle tests in my next PR
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle controller in my next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741582658
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
Could you add some tests for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz merged pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz merged pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r732360594
##########
File path: src/server/capacity_unit_calculator.h
##########
@@ -23,6 +23,13 @@
#include <dsn/perf_counter/perf_counter_wrapper.h>
#include <rrdb/rrdb_types.h>
+namespace dsn {
+namespace utils {
+class token_bucket_throttling_controller;
+}
Review comment:
// namespace utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz merged pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz merged pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741582658
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
Could you add some tests for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740059476
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
+ rpc.error() = dsn::ERR_BUSY;
+ _counter_recent_read_throttling_reject_count->increment();
Review comment:
Next pr consider it, now is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r740037638
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -53,6 +54,12 @@ DSN_DEFINE_int32("pegasus.server",
10,
"hotkey analyse interval in seconds");
+DSN_DEFINE_int32("pegasus.server",
+ read_throttling_by_size_request_count,
+ 1,
+ "the default value of throttling controller of read_throttling_by_size");
Review comment:
the config seem to be useless, which case need change the config?
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
+ rpc.error() = dsn::ERR_BUSY;
+ _counter_recent_read_throttling_reject_count->increment();
Review comment:
I suggest the reject count can be distinct the `size` and `qps`, which we can get the request why exceed the throld
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -274,6 +281,12 @@ void pegasus_server_impl::on_get(get_rpc rpc)
resp.partition_index = _gpid.get_partition_index();
resp.server = _primary_address;
+ if (!_read_size_throttling_controller->get_token(FLAGS_read_throttling_by_size_request_count)) {
Review comment:
exactly should getToken(rpc.size)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #829: feat: support read throttling by size
Posted by GitBox <gi...@apache.org>.
Smityz commented on a change in pull request #829:
URL: https://github.com/apache/incubator-pegasus/pull/829#discussion_r741584311
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle tests in my next PR
##########
File path: src/base/pegasus_const.h
##########
@@ -68,4 +68,6 @@ extern const std::string ROCKSDB_BLOCK_CACHE_ENABLED;
extern const std::string SPLIT_VALIDATE_PARTITION_HASH;
Review comment:
I will add some function tests for all read/write throttle controller in my next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org