You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/27 08:43:23 UTC
[GitHub] [spark] wankunde opened a new pull request, #37316: [SPARK-39893][SQL] Remove Aggregate if it is group only and all grouping and aggregate expressions are foldable
wankunde opened a new pull request, #37316:
URL: https://github.com/apache/spark/pull/37316
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Remove Aggregate if it is group only and all grouping and aggregate expressions are foldable.
For example :
```sql
SELECT distinct 1001 as id , cast('2022-06-03' as date) AS DT FROM testData
```
the grouping expressions are : `[1001, 2022-06-03]`
the aggregate expressions are : `[1001 AS id#274, 2022-06-03 AS DT#275]`
so we can skip scan table testData and remote the aggregate operation.
Before this PR:
```
Aggregate [1001, 2022-06-03], [1001 AS id#274, 2022-06-03 AS DT#275], Statistics(sizeInBytes=16.0 EiB)
+- SerializeFromObject, Statistics(sizeInBytes=8.0 EiB)
+- ExternalRDD [obj#12], Statistics(sizeInBytes=8.0 EiB)
```
After this PR:
```
Project [1001 AS id#218, 2022-06-03 AS DT#219], Statistics(sizeInBytes=2.0 B)
+- OneRowRelation, Statistics(sizeInBytes=1.0 B)
```
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37316: [SPARK-39893][SQL] Push limit 1 to the aggregate's child plan if grouping expressions and aggregate expressions are foldable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37316:
URL: https://github.com/apache/spark/pull/37316#issuecomment-1304941982
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37316: [SPARK-39893][SQL] Push limit 1 to the aggregate's child plan if grouping expressions and aggregate expressions are foldable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37316: [SPARK-39893][SQL] Push limit 1 to the aggregate's child plan if grouping expressions and aggregate expressions are foldable
URL: https://github.com/apache/spark/pull/37316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37316: [SPARK-39893][SQL] Remove redundant aggregate if it is group only and all grouping and aggregate expressions are foldable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37316:
URL: https://github.com/apache/spark/pull/37316#issuecomment-1196459405
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org