You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by suez1224 <gi...@git.apache.org> on 2018/01/25 02:54:10 UTC

[GitHub] flink pull request #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use...

GitHub user suez1224 opened a pull request:

    https://github.com/apache/flink/pull/5355

    [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcite 1.15

    ## Brief change log
      - Update flink-table dependency to use Calcite 1.15
      - Add new codegen from EXTRACT since Calcite 1.15 changed how Extract is converted
      - Copy and fixed SqlGroupedWindowFunction from Calcite. (CALCITE-2133)
      - Copy and fixed RexSimplify from Calcite. (CALCITE-2110)
      - Fix unittests.
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes, as stated in the title)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers:  no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/suez1224/flink flink-7934

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5355
    
----
commit a3a6451edfc6229bcbc95cbf1f87056bcdc33b7b
Author: Shuyi Chen <sh...@...>
Date:   2018-01-10T00:52:56Z

    Upgrade to Calcite 1.15

----


---

[GitHub] flink issue #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcit...

Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/5355
  
    Hi, are there anything new in calcite 1.15 that are critical to flink-table?


---

[GitHub] flink issue #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcit...

Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on the issue:

    https://github.com/apache/flink/pull/5355
  
    @bowenli86 The following two features are related to this PR. 
    [CALCITE-2016] Make item + dot operators work for array (e.g. SELECT orders[5].color FROM t (Shuyi Chen)
    [CALCITE-1867] Allow user-defined grouped window functions (Timo Walther)
    
    Also, Calcite 1.15 added built-in support for simple DDL statements like CREATE and DROP.


---

[GitHub] flink pull request #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5355


---

[GitHub] flink issue #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcit...

Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/5355
  
    @suez1224  Great to learn that!


---