[GitHub] [spark] yaooqinn commented on a diff in pull request #42969: [SPARK-45192][UI] Fix overdue lineInterpolate parameter for graphviz edge

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #42969:
URL: https://github.com/apache/spark/pull/42969#discussion_r1328592006


##########
core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js:
##########
@@ -328,11 +328,12 @@ function preprocessGraphLayout(g, forJob) {
     }
   }
   // Curve the edges
-  var edges = g.edges();
-  for (var j = 0; j < edges.length; j++) {
-    var edge = g.edge(edges[j]);
-    edge.lineInterpolate = "basis";
-  }
+  g.edges().forEach(function (edge) {
+      g.setEdge(edge.v, edge.w, {
+        curve: d3.curveBasis
+      })

Review Comment:
   ```suggestion
       g.setEdge(edge.v, edge.w, {
         curve: d3.curveBasis
       })
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org