You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/08/29 13:21:51 UTC
[GitHub] chenpengfei opened a new pull request #1605: sofix bug: memory leak caused by using unique instances of HystrixCon…
chenpengfei opened a new pull request #1605: sofix bug: memory leak caused by using unique instances of HystrixCon…
URL: https://github.com/apache/incubator-skywalking/pull/1605
…currencyStrategy instead of a single instance
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ * ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
#1604
___
### Bug fix
- Bug description.
app print log info: Over 100 instances of HystrixRequestVariable are being stored. This is likely the sign of a memory leak caused by using unique instances of HystrixConcurrencyStrategy instead of a single instance.
- How to fix?
create one instance of HystrixConcurrencyStrategy and save it, then get the one if needed, not new one instance every time.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services