You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/10/13 12:29:10 UTC
Review Request 26639: [FALCON-801] Increase time to wait instances to
got running
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26639/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-801
https://issues.apache.org/jira/browse/FALCON-801
Repository: falcon-git
Description
-------
optionalTest_updateProcessMakeOptionalCompulsory needs more time for new instances to start. They have got created and are on PREP state until they reach their start time.
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java c8a4754
Diff: https://reviews.apache.org/r/26639/diff/
Testing
-------
test passed
Thanks,
Paul Isaychuk
Re: Review Request 26639: [FALCON-801] Increase time to wait
instances to got running
Posted by Paul Isaychuk <pi...@hortonworks.com>.
> On Oct. 15, 2014, 8:52 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java, line 281
> > <https://reviews.apache.org/r/26639/diff/1/?file=719373#file719373line281>
> >
> > I am not able to understand where start time is being modification in the code. Can you point me to it ?
I debugged it once more and seems like I found the key.
Process start/end time doesn't change in the code. After entity was updated, new bundle job is created on Oozie and its -start time is equal to -end time of last instace which is runnnig under old bundle job (original job). The case is that after 'update' was performed SUCCEEDED and RUNNING instances of old process keep belong to old process(bundle) and all non-triggered instance will belong to new bundle job. Usually we have 2 old process instances SUCCEEDED and 3d instance is not triggered so new bundle job -start time is equal to -end of 2nd instance and new bundle job runs immidiately after 'update' was performed. But sometimes (I don't know the reason, maybe some delays) 3d instance is being triggered earlier and thus it running under old process. New bundle job -start time is 5 minutes later (it equals to -end time of 3d instance instead of 2nd one). Thus bundle job hangs in PREP state until that later time will be reached. As we used 3 minutes it intermittently could fail. Mak
es sense?
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26639/#review56805
-----------------------------------------------------------
On Oct. 13, 2014, 10:29 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26639/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 10:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-801
> https://issues.apache.org/jira/browse/FALCON-801
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> optionalTest_updateProcessMakeOptionalCompulsory needs more time for new instances to start. They have got created and are on PREP state until they reach their start time.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java c8a4754
>
> Diff: https://reviews.apache.org/r/26639/diff/
>
>
> Testing
> -------
>
> test passed
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 26639: [FALCON-801] Increase time to wait
instances to got running
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26639/#review56805
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java
<https://reviews.apache.org/r/26639/#comment97228>
I am not able to understand where start time is being modification in the code. Can you point me to it ?
- Raghav Gautam
On Oct. 13, 2014, 3:29 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26639/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 3:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-801
> https://issues.apache.org/jira/browse/FALCON-801
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> optionalTest_updateProcessMakeOptionalCompulsory needs more time for new instances to start. They have got created and are on PREP state until they reach their start time.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java c8a4754
>
> Diff: https://reviews.apache.org/r/26639/diff/
>
>
> Testing
> -------
>
> test passed
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 26639: [FALCON-801] Increase time to wait
instances to got running
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26639/#review57075
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Oct. 13, 2014, 3:29 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26639/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 3:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-801
> https://issues.apache.org/jira/browse/FALCON-801
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> optionalTest_updateProcessMakeOptionalCompulsory needs more time for new instances to start. They have got created and are on PREP state until they reach their start time.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java c8a4754
>
> Diff: https://reviews.apache.org/r/26639/diff/
>
>
> Testing
> -------
>
> test passed
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 26639: [FALCON-801] Increase time to wait
instances to got running
Posted by Paul Isaychuk <pi...@hortonworks.com>.
> On Oct. 14, 2014, 9:21 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java, line 281
> > <https://reviews.apache.org/r/26639/diff/1/?file=719373#file719373line281>
> >
> > I think we are using 3 mins as of now - which is quite a lot of time. Why is that not sufficient ?
In this test case instance which created after update have start time in a future. Thus they wait not only for input data as usually but they wait on actual time when instance should start. Thats why instances are created, got PREP state and then wait some time for their actual start time.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26639/#review56577
-----------------------------------------------------------
On Oct. 13, 2014, 10:29 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26639/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 10:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-801
> https://issues.apache.org/jira/browse/FALCON-801
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> optionalTest_updateProcessMakeOptionalCompulsory needs more time for new instances to start. They have got created and are on PREP state until they reach their start time.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java c8a4754
>
> Diff: https://reviews.apache.org/r/26639/diff/
>
>
> Testing
> -------
>
> test passed
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 26639: [FALCON-801] Increase time to wait
instances to got running
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26639/#review56577
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java
<https://reviews.apache.org/r/26639/#comment96921>
I think we are using 3 mins as of now - which is quite a lot of time. Why is that not sufficient ?
- Raghav Gautam
On Oct. 13, 2014, 3:29 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26639/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 3:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-801
> https://issues.apache.org/jira/browse/FALCON-801
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> optionalTest_updateProcessMakeOptionalCompulsory needs more time for new instances to start. They have got created and are on PREP state until they reach their start time.
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java c8a4754
>
> Diff: https://reviews.apache.org/r/26639/diff/
>
>
> Testing
> -------
>
> test passed
>
>
> Thanks,
>
> Paul Isaychuk
>
>