[jira] Resolved: (WICKET-1182) MarkupCache::getMarkupStream and forceReload always to false

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-1182.
----------------------------------------

    Resolution: Fixed
      Assignee: Juergen Donnerstag

Thanks for the information. I changed MarkupCache.getMarkupStream to actiually use enforceReload.



> MarkupCache::getMarkupStream and forceReload always to false
> ------------------------------------------------------------
>
>                 Key: WICKET-1182
>                 URL: https://issues.apache.org/jira/browse/WICKET-1182
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Stephane Bailliez
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>
> Following the markup reloading trail, I bumped into:
> MarkupContainer::getAssociatedMarkup(boolean throwsException) does:
>             return
> getApplication().getMarkupSettings().getMarkupCache().getMarkupStream(this,
>                     false, throwException);
> So the 'forceReload' is set to false here. Always. which is ok but...then
> Going on call deeper on MarkupCache::getMarkupStream(...boolean forceReload, ...)
> it's calling:
> // Look for associated markup
> final Markup markup = getMarkup(container, container.getClass(), false);
> the parameter forceReload is ignored (and actually unused) and calling the getMarkup with forceReload = false.
> Is that really normal ? I don't find any comment in the code indicating that it could be normal and in that case it also needs to be documented in the javadoc that for this implementation the parameter is ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.