[jira] [Commented] (BEAM-2091) Typo in build instructions in Apex Runner's README.md

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986256#comment-15986256 ] 

ASF GitHub Bot commented on BEAM-2091:
--------------------------------------

GitHub user tibkiss opened a pull request:

    https://github.com/apache/beam/pull/2735

    [BEAM-2091] Typo in build instructions in Apex Runner's README.md

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tibkiss/beam BEAM-2091

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2735
    
----
commit 33f0f26c445dc2ac65a33babf76a5913a74088c8
Author: Tibor Kiss <ti...@gmail.com>
Date:   2017-04-27T09:20:44Z

    [BEAM-2091] Typo in build instructions in Apex Runner's README.md

----


> Typo in build instructions in Apex Runner's README.md 
> ------------------------------------------------------
>
>                 Key: BEAM-2091
>                 URL: https://issues.apache.org/jira/browse/BEAM-2091
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-apex
>    Affects Versions: First stable release
>            Reporter: Tibor Kiss
>            Assignee: Tibor Kiss
>            Priority: Trivial
>
> Apex Runner contains [build instructions|https://github.com/apache/beam/blame/master/runners/apex/README.md#L47].
> Due to a malformed dash in {{-DskipTests}} the build will fail with missing goal:
> {code}
> [ERROR] Unknown lifecycle phase "‐DskipTests". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]
> {code}
> The fix is trivial: replace the strange dash (0x90) with a proper one (0x2d).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)