You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/21 10:37:01 UTC
[GitHub] [incubator-linkis] jackxu2011 opened a new pull request, #2315: Fix #2314
jackxu2011 opened a new pull request, #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315
### What is the purpose of the change
fix #2314
### Brief change log
(for example:)
- change the delayTime to if (period < 10) 1 else period / 5
- use ByteTimeUtils.msDurationToString replace Utils.msDurationToString
- format some code
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
This change added tests and can be verified as follows:
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- Anything that affects deployment: (no)
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904443736
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/conf/ServerConfiguration.scala:
##########
@@ -65,19 +65,19 @@ object ServerConfiguration extends Logging{
val BDP_TEST_USER = CommonVars("wds.linkis.test.user", "")
val BDP_SERVER_HOME = CommonVars("wds.linkis.server.home", CommonVars("LINKIS_HOME", "").getValue)
- val BDP_SERVER_DISTINCT_MODE = CommonVars("wds.linkis.server.distinct.mode", new Boolean(true))
+ val BDP_SERVER_DISTINCT_MODE: CommonVars[lang.Boolean] = CommonVars("wds.linkis.server.distinct.mode", lang.Boolean.TRUE)
Review Comment:
this Boolean property is used by java, scala boolean can not be recognited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904443736
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/conf/ServerConfiguration.scala:
##########
@@ -65,19 +65,19 @@ object ServerConfiguration extends Logging{
val BDP_TEST_USER = CommonVars("wds.linkis.test.user", "")
val BDP_SERVER_HOME = CommonVars("wds.linkis.server.home", CommonVars("LINKIS_HOME", "").getValue)
- val BDP_SERVER_DISTINCT_MODE = CommonVars("wds.linkis.server.distinct.mode", new Boolean(true))
+ val BDP_SERVER_DISTINCT_MODE: CommonVars[lang.Boolean] = CommonVars("wds.linkis.server.distinct.mode", lang.Boolean.TRUE)
Review Comment:
this Boolean property is used by java, scala boolean can not be recognited by java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904457508
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/utils/VariableUtils.scala:
##########
@@ -237,7 +236,7 @@ object VariableUtils extends Logging {
}
}
if (!expressionCache.contains(expression)) {
- logger.info(s"Variable expression [$str] = $res(变量表达式[$str] = $res)")
+ info(s"Variable expression [$str] = $res(变量表达式[$str] = $res)")
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
peacewong commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r905750512
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/Message.scala:
##########
@@ -95,13 +94,13 @@ object Message {
}
def error(msg: String): Message = error(msg, null)
implicit def error(t: Throwable): Message = {
- Message(status = 1).setMessage(ExceptionUtils.getRootCauseMessage(t)) << ("stack", ExceptionUtils.getFullStackTrace(t))
+ Message(status = 1).setMessage(ExceptionUtils.getRootCauseMessage(t)) << ("stack", ExceptionUtils.getStackTrace(t))
}
implicit def error(e: (String, Throwable)): Message = error(e._1, e._2)
implicit def error(msg: String, t: Throwable): Message = {
- val message = Message(status = 1)
+ val message = Message(status = 1)
message.setMessage(msg)
- if(t != null) message << ("stack", ExceptionUtils.getFullStackTrace(t))
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904457419
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/Message.scala:
##########
@@ -95,13 +94,13 @@ object Message {
}
def error(msg: String): Message = error(msg, null)
implicit def error(t: Throwable): Message = {
- Message(status = 1).setMessage(ExceptionUtils.getRootCauseMessage(t)) << ("stack", ExceptionUtils.getFullStackTrace(t))
+ Message(status = 1).setMessage(ExceptionUtils.getRootCauseMessage(t)) << ("stack", ExceptionUtils.getStackTrace(t))
}
implicit def error(e: (String, Throwable)): Message = error(e._1, e._2)
implicit def error(msg: String, t: Throwable): Message = {
- val message = Message(status = 1)
+ val message = Message(status = 1)
message.setMessage(msg)
- if(t != null) message << ("stack", ExceptionUtils.getFullStackTrace(t))
Review Comment:
use ExceptionUtils.getStackTrace() replace
the commons-lang3 remove the getFullStackTrace method
the reason is after jdk1.4 the getFullStackTrace is not needed, can use getStackTrace replace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#issuecomment-1161589797
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2315](https://codecov.io/gh/apache/incubator-linkis/pull/2315?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4dd470) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/210c9329c36f38c19186ba587ede8971c9642704?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210c932) will **increase** coverage by `1.85%`.
> The diff coverage is `3.84%`.
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2315 +/- ##
===============================================
+ Coverage 20.57% 22.43% +1.85%
- Complexity 1056 1060 +4
===============================================
Files 455 455
Lines 13920 13966 +46
Branches 2192 2202 +10
===============================================
+ Hits 2864 3133 +269
+ Misses 10667 10393 -274
- Partials 389 440 +51
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/linkis/common/ServiceInstance.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vU2VydmljZUluc3RhbmNlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ala/org/apache/linkis/common/utils/LDAPUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdXRpbHMvTERBUFV0aWxzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...scala/org/apache/linkis/common/utils/Logging.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdXRpbHMvTG9nZ2luZy5zY2FsYQ==) | `23.07% <ø> (ø)` | |
| [.../org/apache/linkis/common/utils/RefreshUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdXRpbHMvUmVmcmVzaFV0aWxzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...org/apache/linkis/common/utils/VariableUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdXRpbHMvVmFyaWFibGVVdGlscy5zY2FsYQ==) | `59.52% <0.00%> (+59.52%)` | :arrow_up: |
| [...n/scala/org/apache/linkis/common/utils/Utils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdXRpbHMvVXRpbHMuc2NhbGE=) | `6.75% <7.14%> (-0.10%)` | :arrow_down: |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `33.33% <0.00%> (-1.12%)` | :arrow_down: |
| [...g/apache/linkis/common/variable/VariableType.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdmFyaWFibGUvVmFyaWFibGVUeXBlLnNjYWxh) | `17.80% <0.00%> (+17.80%)` | :arrow_up: |
| [...apache/linkis/common/variable/CustomDateType.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdmFyaWFibGUvQ3VzdG9tRGF0ZVR5cGUuc2NhbGE=) | `57.62% <0.00%> (+57.62%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-linkis/pull/2315/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2315?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2315?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [210c932...e4dd470](https://codecov.io/gh/apache/incubator-linkis/pull/2315?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904444143
##########
linkis-commons/linkis-httpclient/src/main/scala/org/apache/linkis/httpclient/discovery/AbstractDiscovery.scala:
##########
@@ -159,10 +158,10 @@ abstract class AbstractDiscovery extends Discovery with Closeable with Logging {
""
}
if (StringUtils.isBlank(updateUnhealthyUrl)) {
- logger.info(s"${unhealthyUrl} unhealthy url not exists")
+ info(s"${unhealthyUrl} unhealthy url not exists")
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904443736
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/conf/ServerConfiguration.scala:
##########
@@ -65,19 +65,19 @@ object ServerConfiguration extends Logging{
val BDP_TEST_USER = CommonVars("wds.linkis.test.user", "")
val BDP_SERVER_HOME = CommonVars("wds.linkis.server.home", CommonVars("LINKIS_HOME", "").getValue)
- val BDP_SERVER_DISTINCT_MODE = CommonVars("wds.linkis.server.distinct.mode", new Boolean(true))
+ val BDP_SERVER_DISTINCT_MODE: CommonVars[lang.Boolean] = CommonVars("wds.linkis.server.distinct.mode", lang.Boolean.TRUE)
Review Comment:
this Boolean is used by java, scala boolean can not be recognition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
peacewong commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r903647311
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/Message.scala:
##########
@@ -95,13 +94,13 @@ object Message {
}
def error(msg: String): Message = error(msg, null)
implicit def error(t: Throwable): Message = {
- Message(status = 1).setMessage(ExceptionUtils.getRootCauseMessage(t)) << ("stack", ExceptionUtils.getFullStackTrace(t))
+ Message(status = 1).setMessage(ExceptionUtils.getRootCauseMessage(t)) << ("stack", ExceptionUtils.getStackTrace(t))
}
implicit def error(e: (String, Throwable)): Message = error(e._1, e._2)
implicit def error(msg: String, t: Throwable): Message = {
- val message = Message(status = 1)
+ val message = Message(status = 1)
message.setMessage(msg)
- if(t != null) message << ("stack", ExceptionUtils.getFullStackTrace(t))
Review Comment:
What is this replacement for?
##########
linkis-commons/linkis-httpclient/src/main/scala/org/apache/linkis/httpclient/discovery/AbstractDiscovery.scala:
##########
@@ -159,10 +158,10 @@ abstract class AbstractDiscovery extends Discovery with Closeable with Logging {
""
}
if (StringUtils.isBlank(updateUnhealthyUrl)) {
- logger.info(s"${unhealthyUrl} unhealthy url not exists")
+ info(s"${unhealthyUrl} unhealthy url not exists")
Review Comment:
Removing logger is not recommended
##########
linkis-commons/linkis-hadoop-common/src/main/scala/org/apache/linkis/hadoop/common/utils/HDFSUtils.scala:
##########
@@ -119,7 +118,9 @@ object HDFSUtils extends Logging {
def createFileSystem(userName: String, conf: org.apache.hadoop.conf.Configuration): FileSystem =
getUserGroupInformation(userName)
.doAs(new PrivilegedExceptionAction[FileSystem] {
- def run = FileSystem.get(conf)
+ // scalastyle:off FileSystemGet
Review Comment:
recommended removal
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/utils/VariableUtils.scala:
##########
@@ -237,7 +236,7 @@ object VariableUtils extends Logging {
}
}
if (!expressionCache.contains(expression)) {
- logger.info(s"Variable expression [$str] = $res(变量表达式[$str] = $res)")
+ info(s"Variable expression [$str] = $res(变量表达式[$str] = $res)")
Review Comment:
Removing logger is not recommended
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/conf/ServerConfiguration.scala:
##########
@@ -65,19 +65,19 @@ object ServerConfiguration extends Logging{
val BDP_TEST_USER = CommonVars("wds.linkis.test.user", "")
val BDP_SERVER_HOME = CommonVars("wds.linkis.server.home", CommonVars("LINKIS_HOME", "").getValue)
- val BDP_SERVER_DISTINCT_MODE = CommonVars("wds.linkis.server.distinct.mode", new Boolean(true))
+ val BDP_SERVER_DISTINCT_MODE: CommonVars[lang.Boolean] = CommonVars("wds.linkis.server.distinct.mode", lang.Boolean.TRUE)
Review Comment:
Why is there no unified style for Boolean here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2315: Fix #2314 AbstractDiscovery delayTime calculate error
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2315:
URL: https://github.com/apache/incubator-linkis/pull/2315#discussion_r904444302
##########
linkis-commons/linkis-hadoop-common/src/main/scala/org/apache/linkis/hadoop/common/utils/HDFSUtils.scala:
##########
@@ -119,7 +118,9 @@ object HDFSUtils extends Logging {
def createFileSystem(userName: String, conf: org.apache.hadoop.conf.Configuration): FileSystem =
getUserGroupInformation(userName)
.doAs(new PrivilegedExceptionAction[FileSystem] {
- def run = FileSystem.get(conf)
+ // scalastyle:off FileSystemGet
Review Comment:
this is for ide style check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org