[GitHub] [cloudstack] GutoVeronezi commented on issue #3609: Improve Guest OS additions and mappings

[GitBox <gi...@apache.org>]

GutoVeronezi commented on issue #3609:
URL: https://github.com/apache/cloudstack/issues/3609#issuecomment-802989353


   @rhtyd There is a PR (https://github.com/apache/cloudstack/pull/4699) that I think would solve this situation.
   It was created a procedure that will add `guest_os + hypervisor` mapping;
   - To each new map, call the procedure;
   - If the map already exists (validating name and category), it will skip it;
   - The procedure respects the `AUTO_INCREMENT` columns;
   - After generate the `guest_os.id`, it will retrieve it to use in `guest_os_hypervisor`;
   
   If this PR (https://github.com/apache/cloudstack/pull/4699) is accepted, then we need to ensure that every PR, that add new `guest_os + hypervisor` mappings, uses the procedure.
   
   Could you take a look a it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org