You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2021/12/24 13:10:57 UTC

[GitHub] [jclouds] gaul commented on a change in pull request #128: Update ClientCredentialsClaims.java

gaul commented on a change in pull request #128:
URL: https://github.com/apache/jclouds/pull/128#discussion_r775010584



##########
File path: apis/oauth/src/main/java/org/jclouds/oauth/v2/domain/ClientCredentialsClaims.java
##########
@@ -49,6 +50,7 @@
     public abstract long nbf();
 
     /** "JWT ID", a unique identifier for the JWT. */
+    @Nullable

Review comment:
       Should this also annotate the `create` method with `@Nullable` as the [AutoValue documentation suggests](https://github.com/google/auto/blob/master/value/userguide/howto.md#nullable)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org