[bookkeeper] branch master updated: Issue #1282: call to appendLedgersMap in flushCompactionLog

[si...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 2bd24b7  Issue #1282: call to appendLedgersMap in flushCompactionLog
2bd24b7 is described below

commit 2bd24b7bbd531261bb5ca203b02575b1b1eb4890
Author: cguttapalem <cg...@salesforce.com>
AuthorDate: Wed Mar 28 22:19:37 2018 -0700

    Issue #1282: call to appendLedgersMap in flushCompactionLog
    
    Descriptions of the changes in this PR:
    
    with this change https://github.com/apache/bookkeeper/commit/3392beee5c70abe36d36604723e14d97b7764be9 compactionlog was introduced. But for compactionlog call to appendLedgersMap (// Append ledgers map at the end of entry log) isn't made.
    
    So for these logs, getEntryLogMetadata call has to call extractEntryLogMetadataByScanning for getting the metadata of entrylog. Which is a perf hit.
    
    Master Issue: #1282
    
    Author: cguttapalem <cg...@salesforce.com>
    
    Reviewers: Yiming Zang <yz...@gmail.com>, Sijie Guo <si...@apache.org>
    
    This closes #1283 from reddycharan/compactionlogfix, closes #1282
---
 .../src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java          | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
index 0df8607..2055758 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
@@ -943,6 +943,7 @@ public class EntryLogger {
     void flushCompactionLog() throws IOException {
         synchronized (compactionLogLock) {
             if (compactionLogChannel != null) {
+                appendLedgersMap(compactionLogChannel);
                 compactionLogChannel.flushAndForceWrite(false);
                 LOG.info("Flushed compaction log file {} with logId.",
                     compactionLogChannel.getLogFile(),

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.