You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2022/05/02 23:58:17 UTC

[kudu-CR] server: link in kudu jwt util

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18470


Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644
PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true));
> Is this a functional verifier?  In other words, can it verify any tokens at
Same question here. empty jwks_uri does not provide valid JWKS.



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 06:57:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644
PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true));
Is this a functional verifier?  In other words, can it verify any tokens at all?

Also, could you help me to understand where's the call for the JwtVerifier::Init() is supposed to happen: just here, or as a part of Messenger::Init(), or somewhere else?



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 20:34:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Dec 2022 23:51:06 +0000
Gerrit-HasComments: No

[kudu-CR] server: link in kudu jwt util

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc@661
PS4, Line 661: LAGS_keytab_file)
> JwtVerifier is base class. We need to use KeyBasedJwtVerifier
How about std::make_shared<KeyBasedJwtVerifier>("", true)?



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 18:47:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#4) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/negotiation-test.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
M src/kudu/util/jwt-util.cc
4 files changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#8) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
4 files changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#14) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
5 files changed, 17 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/14
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 14
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 10:

(2 comments)

Many Python tests have failed with error like

Runtime error: Failed to load JWKS: Could not open JWKS file ''; No such file or directory

IWYU isn't happy yet:

http://jenkins.kudu.apache.org/job/kudu-gerrit/26876/BUILD_TYPE=IWYU/artifact/build/latest/test-logs/iwyu.log

http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:

http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h@387
PS10, Line 387:   JwtVerifier* const jwt_verifier() const { return jwt_verifier_.get(); }
> warning: return type 'kudu::JwtVerifier *const' is 'const'-qualified at the
This signature doesn't make much sense, and TidyBot posted about that.


http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644
PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true));
> no, it is not a functional verifier, it's a placeholder, the actual values 
Ah, I see: thanks for the pointer.

With that, is it possible to leave jwt_verifier as a nullptr wrapper (i.e. not call Messenger::set_jwt_verifier()) if that's not a functional verifier anyways?



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 23:18:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#10) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
6 files changed, 24 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#13) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
5 files changed, 17 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/13
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 13
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc@661
PS4, Line 661: std::move(jwt_verifier)
> Remove the definition of jwt_verifier at line 645 and replace this std::mov
JwtVerifier is base class. We need to use KeyBasedJwtVerifier



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Nov 2022 03:46:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc@661
PS4, Line 661: std::move(jwt_verifier)
Remove the definition of jwt_verifier at line 645 and replace this std::move(...) with

  std::make_shared<JwtVerifier>("", true)

Overall, prefer std::make_shared over constructing std::shared_ptr via regular constructor since the former is more efficient in most implementations in terms of making just one memory allocation instead of two: https://en.cppreference.com/w/cpp/memory/shared_ptr/make_shared



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Nov 2022 02:03:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#7) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/negotiation-test.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
5 files changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#15) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
5 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/15
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 15
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 15: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 15
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 20:00:35 +0000
Gerrit-HasComments: No

[kudu-CR] server: link in kudu jwt util

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 15: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 15
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 19:26:24 +0000
Gerrit-HasComments: No

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 3:

It seems IWYU isn't happy yet.

Also, there is a bunch of failures due to UBSAN warnings in

DeleteTabletITest.TestLeaderElectionDuringDeleteTablet
ExactlyOnceRpcTest.TestExactlyOnceSemanticsAfterRpcCompleted
MultiThreadedRpcTest.TestShutdownDuringService
RpcProxyTest.TestProxyRetriesWhenRequestLeavesScope
RpcBench.BenchmarkCalls
Parameters/TestRpc.TestCall/NoSSL_UnixSocket
Parameters/TestRpc.TestCall/SSL_TCP
Parameters/TestRpc.TestCall/SSL_UnixSocket
Parameters/TestRpc.TestNegotiationDeadlock/NoSSL_TCP
Parameters/TestRpc.TestNegotiationDeadlock/NoSSL_UnixSocket


-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Nov 2022 03:24:01 +0000
Gerrit-HasComments: No

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#6) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/negotiation-test.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
5 files changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Reviewed-on: http://gerrit.cloudera.org:8080/18470
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
5 files changed, 16 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Wenzhe Zhou: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 16
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc@661
PS4, Line 661: LAGS_keytab_file)
> How about std::make_shared<KeyBasedJwtVerifier>("", true)?
Indeed using make_shared would be nicer, however in follow up patches the value of the jwt_verifier will be set based on configurations, so the separate variable will be needed anyways.


http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644
PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true));
> Same question here. empty jwks_uri does not provide valid JWKS.
no, it is not a functional verifier, it's a placeholder, the actual values will be passed via config flags in the next patch:
https://gerrit.cloudera.org/c/18471/5/src/kudu/server/server_base.cc#658

also I've added the Init() to the MessengerBuilder::Build() method



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 18:53:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#11) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
6 files changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#12) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/server/CMakeLists.txt
M src/kudu/util/jwt-util.h
M src/kudu/util/jwt.h
5 files changed, 17 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 12
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 12:

(2 comments)

> Patch Set 12: Verified-1
> 
> Build Failed 
> 
> http://jenkins.kudu.apache.org/job/kudu-gerrit/26878/ : FAILURE

not sure why the IWYU build failed the last time, I'll re-trigger it

http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:

http://gerrit.cloudera.org:8080/#/c/18470/10/src/kudu/rpc/messenger.h@387
PS10, Line 387:   JwtVerifier* jwt_verifier() const { return jwt_verifier_.get(); }
> This signature doesn't make much sense, and TidyBot posted about that.
Done


http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644
PS9, Line 644:        .set_rpc_negotiation_timeout_ms(FLAGS_rpc_negotiation_timeout_ms)
> Ah, I see: thanks for the pointer.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 12
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 13:01:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/14/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:

http://gerrit.cloudera.org:8080/#/c/18470/14/src/kudu/rpc/messenger.h@387
PS14, Line 387: JwtVerifier* jwt_verifier() const { return jwt_verifier_.get(); }
This isn't a const-correct method.  Maybe, remove this one altogether and use mutable_jwt_verifier() where necessary?

https://isocpp.org/wiki/faq/const-correctness#return-const-ref-from-const-memfn



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 14
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 17:43:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18470/14/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:

http://gerrit.cloudera.org:8080/#/c/18470/14/src/kudu/rpc/messenger.h@387
PS14, Line 387: const JwtVerifier* jwt_verifier() const { return jwt_verifier_.ge
> This isn't a const-correct method.  Maybe, remove this one altogether and u
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 15
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 10:43:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] server: link in kudu jwt util

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has uploaded a new patch set (#5) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18470 )

Change subject: server: link in kudu_jwt_util
......................................................................

server: link in kudu_jwt_util

Co-authored-by: Zoltan Chovan <zc...@cloudera.com>

Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/negotiation-test.cc
M src/kudu/server/CMakeLists.txt
M src/kudu/server/server_base.cc
5 files changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/18470/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a
Gerrit-Change-Number: 18470
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>