You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/15 01:56:31 UTC

[GitHub] [spark] allisonport-db commented on pull request #38823: [SPARK-41290][SQL] Support GENERATED ALWAYS AS expressions for columns in create/replace table statements

allisonport-db commented on PR #38823:
URL: https://github.com/apache/spark/pull/38823#issuecomment-1352455011

   > Does the SQL standard say anything about the restrictions of the generate expression? Can we allow `GENERATED AS rand()`? I think at least catalyst should have a rule to check the expression and make sure the data type is the same as column type.
   
   Checking for data type make sense.
   
   Other restrictions we can enforce
   - no UDFs
   - only deterministic functions
   - no subqueries
   - no window functions
   - no aggregate functions
   - no generator functions
   - interdependence with other generated columns


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org