You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhenlineo (via GitHub)" <gi...@apache.org> on 2023/06/13 00:40:31 UTC
[GitHub] [spark] zhenlineo commented on a diff in pull request #41501: [WIP][Connect] Rewrite the keyValueGrouppedDS plan to simplify the mapValues logic
zhenlineo commented on code in PR #41501:
URL: https://github.com/apache/spark/pull/41501#discussion_r1227377062
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1194,6 +1190,18 @@ class SparkConnectPlanner(val session: SparkSession) extends Logging {
val projection = rel.getExpressionsList.asScala.toSeq
.map(transformExpression)
+ .map { expr =>
+ expr transform {
+ case f: ScalaUDF if hasUnresolvedStartAsInput(f) =>
Review Comment:
Should I analyze on the input too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org