You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/03 21:09:50 UTC
[GitHub] [pulsar-dotpulsar] usaguerrilla opened a new issue #53: Memory leak in DotPulsar.Internal.AsyncQueue
usaguerrilla opened a new issue #53:
URL: https://github.com/apache/pulsar-dotpulsar/issues/53
```
public void Enqueue(T item)
{
lock (_lock)
{
ThrowIfDisposed();
if (_pendingDequeues.Count > 0)
{
var tcs = _pendingDequeues.First;
_pendingDequeues.RemoveFirst();
tcs.Value.SetResult(item);
}
else
_queue.Enqueue(item);
}
}
```
missing ```tcs.Value.Dispose();```
Should be:
```
public void Enqueue(T item)
{
lock (_lock)
{
ThrowIfDisposed();
if (_pendingDequeues.Count > 0)
{
var tcs = _pendingDequeues.First;
_pendingDequeues.RemoveFirst();
tcs.Value.SetResult(item);
tcs.Value.Dispose();
}
else
_queue.Enqueue(item);
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #53: Memory leak in DotPulsar.Internal.AsyncQueue
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #53:
URL: https://github.com/apache/pulsar-dotpulsar/issues/53#issuecomment-686785280
Sounds great! I'll merge your upcoming PR and create a new release tomorrow :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner closed issue #53: Memory leak in DotPulsar.Internal.AsyncQueue
Posted by GitBox <gi...@apache.org>.
blankensteiner closed issue #53:
URL: https://github.com/apache/pulsar-dotpulsar/issues/53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #53: Memory leak in DotPulsar.Internal.AsyncQueue
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #53:
URL: https://github.com/apache/pulsar-dotpulsar/issues/53#issuecomment-686946118
Fixed by PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] usaguerrilla commented on issue #53: Memory leak in DotPulsar.Internal.AsyncQueue
Posted by GitBox <gi...@apache.org>.
usaguerrilla commented on issue #53:
URL: https://github.com/apache/pulsar-dotpulsar/issues/53#issuecomment-686782066
sure! I did test it and it works. Task completes and result is success. memory is stable so far. Consumed 400'000 messages with 8 partition topic. Holding at 38Mb.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #53: Memory leak in DotPulsar.Internal.AsyncQueue
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #53:
URL: https://github.com/apache/pulsar-dotpulsar/issues/53#issuecomment-686775849
Hi @usaguerrilla
I think you are right, nice catch! Up for creating a PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org