You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cocoon.apache.org by Donald Ball <ba...@webslingerZ.com> on 2001/04/03 20:47:42 UTC
Re: [C1.8.2] sendmail.xsl update
On Tue, 3 Apr 2001, Drasko Kokic wrote:
> here is a proposal for the extended sendmail.xsl
>
> The following elements are being add:
> sendmail:reply-to
> sendmail:to
> sendmail:cc
> sendmail:bcc
> These elements could also apear more than once
>
> For the debuging purposes there is a new
> sendmail:debug element
overall, i like this patch. if i may make a few requests before i import
this:
1. please prefix all variables with _sendmail_. i don't think was done
consistently in the existing cvs source, but it should be.
2. i believe you should use <> instead of the entities in attribute values
like this:
<xsl:if test="count(sendmail:reply-to) > 0">
3. please add yourself to the author list at the top of the file. :)
4. send a unified context diff
thanks!
- donald
---------------------------------------------------------------------
Please check that your question has not already been answered in the
FAQ before posting. <http://xml.apache.org/cocoon/faqs.html>
To unsubscribe, e-mail: <co...@xml.apache.org>
For additional commands, e-mail: <co...@xml.apache.org>
Re: [C1.8.2] sendmail.xsl update
Posted by Donald Ball <ba...@webslingerZ.com>.
On Wed, 4 Apr 2001, Drasko Kokic wrote:
> thanks donald ... with regards to your small change
> ... i hope you have left variable i in "for (int i=0;
> i<_sendmail_addrs.length; i++)" unchanged :-)
er, actually, i should change that too...
> seriously, how small the logical block should be so
> that local variables don't need to have predifined
> prefix in their names?
it's mostly collisions with variables in the user's xsp pages that i'm
worried about.
> p.s. i am going to get the cvs installed so that i can
> do diff's in future
score.
- donald
---------------------------------------------------------------------
Please check that your question has not already been answered in the
FAQ before posting. <http://xml.apache.org/cocoon/faqs.html>
To unsubscribe, e-mail: <co...@xml.apache.org>
For additional commands, e-mail: <co...@xml.apache.org>
Re: [C1.8.2] sendmail.xsl update
Posted by Drasko Kokic <dr...@yahoo.com>.
--- Donald Ball <ba...@webslingerZ.com> wrote:
> On Tue, 3 Apr 2001, Drasko Kokic wrote:
>
> and it's in cvs, thanks - i did have to fix the
> exception variable names,
> but that's my only change.
>
> - donald
>
thanks donald ... with regards to your small change
... i hope you have left variable i in "for (int i=0;
i<_sendmail_addrs.length; i++)" unchanged :-)
seriously, how small the logical block should be so
that local variables don't need to have predifined
prefix in their names?
p.s. i am going to get the cvs installed so that i can
do diff's in future
__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail.
http://personal.mail.yahoo.com/
---------------------------------------------------------------------
Please check that your question has not already been answered in the
FAQ before posting. <http://xml.apache.org/cocoon/faqs.html>
To unsubscribe, e-mail: <co...@xml.apache.org>
For additional commands, e-mail: <co...@xml.apache.org>
Re: [C1.8.2] sendmail.xsl update
Posted by Donald Ball <ba...@webslingerZ.com>.
On Tue, 3 Apr 2001, Drasko Kokic wrote:
and it's in cvs, thanks - i did have to fix the exception variable names,
but that's my only change.
- donald
---------------------------------------------------------------------
Please check that your question has not already been answered in the
FAQ before posting. <http://xml.apache.org/cocoon/faqs.html>
To unsubscribe, e-mail: <co...@xml.apache.org>
For additional commands, e-mail: <co...@xml.apache.org>
Re: [C1.8.2] sendmail.xsl update
Posted by Drasko Kokic <dr...@yahoo.com>.
--- Uli Mayring <ul...@denic.de> wrote:
> On Tue, 3 Apr 2001, Donald Ball wrote:
>
> > <xsl:if test="count(sendmail:reply-to)
> > 0">
>
> I usually write
>
> <xsl:if test="sendmail:reply-to">
>
> It's shorter and avoids the function call.
>
> Ulrich
>
> --
> Ulrich Mayring
> DENIC eG, Softwareentwicklung
>
done ... thanks :-)
__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail.
http://personal.mail.yahoo.com/
Re: [C1.8.2] sendmail.xsl update
Posted by Uli Mayring <ul...@denic.de>.
On Tue, 3 Apr 2001, Donald Ball wrote:
> <xsl:if test="count(sendmail:reply-to) > 0">
I usually write
<xsl:if test="sendmail:reply-to">
It's shorter and avoids the function call.
Ulrich
--
Ulrich Mayring
DENIC eG, Softwareentwicklung
---------------------------------------------------------------------
Please check that your question has not already been answered in the
FAQ before posting. <http://xml.apache.org/cocoon/faqs.html>
To unsubscribe, e-mail: <co...@xml.apache.org>
For additional commands, e-mail: <co...@xml.apache.org>
Re: [C1.8.2] sendmail.xsl update
Posted by Donald Ball <ba...@webslingerZ.com>.
On Tue, 3 Apr 2001, Drasko Kokic wrote:
> all done, except no. 4 (don't have any diff on my Win
> box - could you maybe help :-)
i believe the windows cvs client has a diff utility built in...? from the
unix command line, you do:
cvs diff -c whatever.file
- donald
---------------------------------------------------------------------
Please check that your question has not already been answered in the
FAQ before posting. <http://xml.apache.org/cocoon/faqs.html>
To unsubscribe, e-mail: <co...@xml.apache.org>
For additional commands, e-mail: <co...@xml.apache.org>
Re: [C1.8.2] sendmail.xsl update
Posted by Drasko Kokic <dr...@yahoo.com>.
--- Donald Ball <ba...@webslingerZ.com> wrote:
> On Tue, 3 Apr 2001, Drasko Kokic wrote:
>
> > here is a proposal for the extended sendmail.xsl
> >
> > The following elements are being add:
> > sendmail:reply-to
> > sendmail:to
> > sendmail:cc
> > sendmail:bcc
> > These elements could also apear more than once
> >
> > For the debuging purposes there is a new
> > sendmail:debug element
>
> overall, i like this patch. if i may make a few
> requests before i import
> this:
>
> 1. please prefix all variables with _sendmail_. i
> don't think was done
> consistently in the existing cvs source, but it
> should be.
>
> 2. i believe you should use <> instead of the
> entities in attribute values
> like this:
>
> <xsl:if test="count(sendmail:reply-to) >
> 0">
>
> 3. please add yourself to the author list at the top
> of the file. :)
>
> 4. send a unified context diff
>
> thanks!
>
> - donald
>
all done, except no. 4 (don't have any diff on my Win
box - could you maybe help :-)
cheers
__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail.
http://personal.mail.yahoo.com/