You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ChrisHegarty (via GitHub)" <gi...@apache.org> on 2023/11/04 15:05:53 UTC
[PR] Remove usage of deprecated java.util.Locale constructor [lucene]
ChrisHegarty opened a new pull request, #12761:
URL: https://github.com/apache/lucene/pull/12761
This commit removes usages of the deprecated `java.util.Locale` constructor with `Locale.Builder`.
The motivation for this change is to address tech debt identified when experimenting with bumping to Java 21.
The changes in this PR are, for the most part, from @rmuir. Extracted out of #12753.
relates #12753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Remove usage of deprecated java.util.Locale constructor [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #12761:
URL: https://github.com/apache/lucene/pull/12761#issuecomment-1793871445
> Looks ok to me.
>
> Did you check all possible benchmark config/ALG files (not all of them are tested) that the locales in them are correctly for usage as language tag?
```
$ git grep NewLocale
conf/collation.alg: -NewLocale(fr)
conf/collation.alg: -NewLocale(de)
conf/collation.alg: -NewLocale(uk)
conf/collation.alg: -NewLocale(en)
conf/collation.alg: -NewLocale(fr)
conf/collation.alg: -NewLocale(de)
conf/collation.alg: -NewLocale(uk)
conf/collation.alg: -NewLocale(en)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Remove usage of deprecated java.util.Locale constructor [lucene]
Posted by "ChrisHegarty (via GitHub)" <gi...@apache.org>.
ChrisHegarty merged PR #12761:
URL: https://github.com/apache/lucene/pull/12761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org