[GitHub] spark issue #19235: [SPARK-21997][SQL][WIP] Turn off spark.sql.hive.convertM...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/19235
  
    > I wanted to raise this issue of convertMetastoreXXX things since convertMetastoreXXX seems not to be tested completly
    
    That's fine, but that's not what your change is proposing. If you look at the test failures, at least the one I looked at is because the wrong exception is being thrown, not because the feature is broken. That doesn't excuse the fact that it's not tested, but maybe the situation is not that dire.
    
    But as Xiao has mentioned, you're not fixing the problem you describe in the change summary; you haven't even root caused the problem. You just found out that using Hive classes to read the parquet data works around the problem, but that's not an acceptable fix for the problem - it's just a workaround that those affected by the issue can use.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org