You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-users@xmlgraphics.apache.org by jonathan wood <jo...@gmail.com> on 2009/12/31 23:28:15 UTC

contribution advice?

Happy New Year Batikeers,

    I have a few enhancements I'd like to add to batik, but I'm not quite
finished scoping/designing in that arena.  In the meantime, I'm starting to
absorb more of the core code.  I find it usually helps me if I have a goal.
Perhaps someone familiar with the current state of batik's bug list
(Helder???) could point me toward some validated, higher priority bugs so
that I might attempt to resolve?

  My Apache ICLA has been submitted and I do understand that I will be
limited to submitting patches that may or may not be applied by an
individual with commit access.


  Thanks,

    jonathan

ICLA on file [was: Re: contribution advice?]

Posted by Simon Pepping <sp...@leverkruid.eu>.
On Thu, Dec 31, 2009 at 05:28:15PM -0500, jonathan wood wrote:
> 
>   My Apache ICLA has been submitted and I do understand that I will be
> limited to submitting patches that may or may not be applied by an
> individual with commit access.

Your ICLA is now on file. We hope for many interesting contributions
from you.

Regards, Simon

-- 
Simon Pepping
home page: http://www.leverkruid.eu

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


Re: contribution advice?

Posted by jonathan wood <jo...@gmail.com>.
This is exactly what I was looking for.  Thanks for taking the time to put
this together!


On Fri, Jan 8, 2010 at 9:15 AM, <th...@kodak.com> wrote:

> Hi Jonathan,
>
> jonathan wood <jo...@gmail.com> wrote on 12/31/2009 05:28:15
> PM:
>
>
> >     Perhaps someone familiar with the current state of batik's bug
>
> > list (Helder???) could point me toward some validated, higher priority
> > bugs so that I might attempt to resolve?
>
>    I'm not sure there are a lot of high priority bugs.  I'll list a few
> things that have been on my TODO list (for a few years now ;).
>
> 1) Pipe all element "lookups" through an object associated with the
>    BridgeContext.  This would be to serve two purposes.  First it
>    would more easily enable people to 'replace' Batik's lookup/fetch
>    logic (replacing/augmenting ParsedURL only goes so far).  Second
>    if paired with 'unlookup' calls it would enable Batik to detect
>    complex reference loops in content (an element that references a
>    pattern that uses the element).
>
> 2) Make everything use ParsedURL for references.  Currently there
>    are still a few places where we don't use ParsedURL (I think
>    mostly in CSS) this mostly means that you can't use base64
>    encoded URLS in these places.
>
> 3) Add dynamic updates for referenced content. Currently in many
>    cases if a referenced element changes Batik doesn't notice.  I
>    think this is true for patterns, filters, masks, etc.  I did an
>    example of dependency tracking for gradients (which may not have
>    landed on trunk) at some point it would be nice if this was extended
>    to other areas.
>
> 4) Implement ElementInstance for Use elements.  Currently we create a
>    shadow tree to support the use element, which is not conformant to
>    the SVG specification.  It would be better if we created
> ElementInstances
>    that could carry the CSS cascade information and then use a reference
>    to the actual element for DOM attributes.  This would require updating
>    all of the Bridges to know/handle the ElementInstance case but I think
>    the changes (while widespread) could be fairly simple.
>
>    These are just suggestions, let me know if these are the sorts of
> suggestions you are looking for, or if your interested lie in other areas.
>
> >   My Apache ICLA has been submitted and I do understand that I will
> > be limited to submitting patches that may or may not be applied by
> > an individual with commit access.
> >
> >
> >   Thanks,
> >
> >     jonathan
>

Re: contribution advice?

Posted by th...@kodak.com.
Hi Jonathan,

jonathan wood <jo...@gmail.com> wrote on 12/31/2009 05:28:15 
PM:

>     Perhaps someone familiar with the current state of batik's bug 
> list (Helder???) could point me toward some validated, higher priority 
> bugs so that I might attempt to resolve?

   I'm not sure there are a lot of high priority bugs.  I'll list a few
things that have been on my TODO list (for a few years now ;).

1) Pipe all element "lookups" through an object associated with the 
   BridgeContext.  This would be to serve two purposes.  First it
   would more easily enable people to 'replace' Batik's lookup/fetch
   logic (replacing/augmenting ParsedURL only goes so far).  Second
   if paired with 'unlookup' calls it would enable Batik to detect
   complex reference loops in content (an element that references a
   pattern that uses the element).

2) Make everything use ParsedURL for references.  Currently there
   are still a few places where we don't use ParsedURL (I think
   mostly in CSS) this mostly means that you can't use base64 
   encoded URLS in these places.

3) Add dynamic updates for referenced content. Currently in many
   cases if a referenced element changes Batik doesn't notice.  I
   think this is true for patterns, filters, masks, etc.  I did an
   example of dependency tracking for gradients (which may not have
   landed on trunk) at some point it would be nice if this was extended 
   to other areas.

4) Implement ElementInstance for Use elements.  Currently we create a
   shadow tree to support the use element, which is not conformant to
   the SVG specification.  It would be better if we created 
ElementInstances
   that could carry the CSS cascade information and then use a reference
   to the actual element for DOM attributes.  This would require updating
   all of the Bridges to know/handle the ElementInstance case but I think
   the changes (while widespread) could be fairly simple.

   These are just suggestions, let me know if these are the sorts of
suggestions you are looking for, or if your interested lie in other areas.

>   My Apache ICLA has been submitted and I do understand that I will 
> be limited to submitting patches that may or may not be applied by 
> an individual with commit access.
> 
> 
>   Thanks,
> 
>     jonathan

Re: contribution advice?

Posted by Helder Magalhães <he...@gmail.com>.
Hi jonathan,


I'd suggest taking this sort of discussions in batik-dev. That mailing
list is not only for Batik committers, it's meant for "developers
working on or wanting to work on Batik itself" [1]. ;-)


Response inline...


> Happy New Year Batikeers,

Thanks! I hope it will be a great year for Batik and SVG in general. :-)


>     I have a few enhancements I'd like to add to batik [...]

Cool! B-)


> I find it usually helps me if I have a goal.
> Perhaps someone familiar with the current state of batik's bug list
> (Helder???) could point me toward some validated, higher priority bugs so
> that I might attempt to resolve?

I already shared my TODO list recently [2] and I must confess I don't
have any insights about Batik internals needing some love but, as
Thomas already hinted a few, I don't think it will be much necessary.
:-)

I'd only add that helping out triaging hanging bugs (without patches
[4]) or testing existing patches [5] might help while entering the
project (at least, from my experience). Nevertheless, given that your
Java skills seem to be above average, I'd say working in the code base
itself (following Thomas ideas) would bring more value to the project.
Just my 2 cents... :-)


>   My Apache ICLA has been submitted and I do understand that I will be
> limited to submitting patches that may or may not be applied by an
> individual with commit access.

Yes, I just noticed it was already received and processed ("Jonathan
Shaw Wood" became part of the list [5]). :-)


>   Thanks,
>     jonathan

Cheers,
 Helder


[1] http://xmlgraphics.apache.org/batik/mailing-lists.html#batik-dev
[2] http://old.nabble.com/Welcome-to-Helder-Magalh%C3%A3es-as-a-committer-td26962973.html#a26981465
[3] https://issues.apache.org/bugzilla/buglist.cgi?query_format=specific&product=Batik&bug_status=__open__&short_desc=\[PATCH\]&short_desc_type=notregexp
[4] https://issues.apache.org/bugzilla/buglist.cgi?query_format=specific&product=Batik&bug_status=__open__&short_desc=\[PATCH\]&short_desc_type=regexp
[5] http://people.apache.org/~jim/committers.html#unlistedclas

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-users-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-users-help@xmlgraphics.apache.org