[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #7089: Make TableConfigTunerRegistry configurable to scan packages.

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #7089:
URL: https://github.com/apache/incubator-pinot/pull/7089#discussion_r659031873



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -66,6 +66,10 @@
   public static final String CONTROLLER_MODE = "controller.mode";
   public static final String LEAD_CONTROLLER_RESOURCE_REBALANCE_STRATEGY = "controller.resource.rebalance.strategy";
 
+  // Comma separated list of list of packages that contain TableConfigTuners to be added to the registry
+  public static final String TABLE_CONFIG_TUNER_PACKAGES = "controller.table.config.tuner.packages";
+  public static final String DEFAULT_TABLE_CONFIG_TUNER_PACKAGES = TableConfigTunerRegistry.class.getPackage().getName();

Review comment:
       Yes, I didn't want to hardcode it, and I also thought it might be better to be specific. But on second thought, better to keep previous behavior.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org