You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/03/06 10:35:14 UTC

[GitHub] spark pull request #17150: [SPARK-19810][BUILD][CORE] Remove support for Sca...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17150#discussion_r104383644
  
    --- Diff: dev/create-release/release-build.sh ---
    @@ -342,16 +342,13 @@ if [[ "$1" == "publish-release" ]]; then
     
       $MVN -DzincPort=$ZINC_PORT -Dmaven.repo.local=$tmp_repo -DskipTests $PUBLISH_PROFILES clean install
     
    -  ./dev/change-scala-version.sh 2.10
    -
    -  $MVN -DzincPort=$ZINC_PORT -Dmaven.repo.local=$tmp_repo -Dscala-2.10 \
    -    -DskipTests $PUBLISH_PROFILES clean install
    +  #./dev/change-scala-version.sh 2.12
    +  #$MVN -DzincPort=$ZINC_PORT -Dmaven.repo.local=$tmp_repo -Pscala-2.12 \
    +  #  -DskipTests $PUBLISH_PROFILES clean install
     
       # Clean-up Zinc nailgun process
       /usr/sbin/lsof -P |grep $ZINC_PORT | grep LISTEN | awk '{ print $2; }' | xargs kill
     
    -  ./dev/change-version-to-2.10.sh
    --- End diff --
    
    This was redundant with the line 8 lines above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org