You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/10/10 15:13:24 UTC

Review Request 62866: Make hive server create directories related to replication

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Bugs: AMBARI-22188
    https://issues.apache.org/jira/browse/AMBARI-22188


Repository: ambari


Description
-------

make sure that hive directories needed by replication is created on hive server start if configured


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 8e176b69ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 1d68ef4217 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py e7e92ec985 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py f6b676b65e 


Diff: https://reviews.apache.org/r/62866/diff/1/


Testing
-------

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy


Re: Review Request 62866: Make hive server create directories related to replication

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/#review187658
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 11, 2017, 5:44 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62866/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 5:44 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-22188
>     https://issues.apache.org/jira/browse/AMBARI-22188
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> make sure that hive directories needed by replication is created on hive server start if configured
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml d66cf4c1a8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 8e176b69ac 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 1d68ef4217 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml edbbc9d10e 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py e7e92ec985 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py f6b676b65e 
> 
> 
> Diff: https://reviews.apache.org/r/62866/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 62866: Make hive server create directories related to replication

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/
-----------------------------------------------------------

(Updated Oct. 11, 2017, 2:44 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
-------

do not add properties on upgrade


Bugs: AMBARI-22188
    https://issues.apache.org/jira/browse/AMBARI-22188


Repository: ambari


Description
-------

make sure that hive directories needed by replication is created on hive server start if configured


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml d66cf4c1a8 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 8e176b69ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 1d68ef4217 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml edbbc9d10e 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py e7e92ec985 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py f6b676b65e 


Diff: https://reviews.apache.org/r/62866/diff/3/

Changes: https://reviews.apache.org/r/62866/diff/2-3/


Testing
-------

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy


Re: Review Request 62866: Make hive server create directories related to replication

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/#review187651
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
Lines 700 (patched)
<https://reviews.apache.org/r/62866/#comment264708>

    After Ambari 2.5, we usually tend to avoid adding/modifying configs during Ambari upgrade


- Dmitro Lisnichenko


On Oct. 11, 2017, 3:09 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62866/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 3:09 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-22188
>     https://issues.apache.org/jira/browse/AMBARI-22188
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> make sure that hive directories needed by replication is created on hive server start if configured
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml d66cf4c1a8 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 8e176b69ac 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 1d68ef4217 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml edbbc9d10e 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py e7e92ec985 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py f6b676b65e 
> 
> 
> Diff: https://reviews.apache.org/r/62866/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 62866: Make hive server create directories related to replication

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/
-----------------------------------------------------------

(Updated Oct. 11, 2017, 12:09 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
-------

Add directory creation to metastore. Add properties descriptions.


Bugs: AMBARI-22188
    https://issues.apache.org/jira/browse/AMBARI-22188


Repository: ambari


Description
-------

make sure that hive directories needed by replication is created on hive server start if configured


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml d66cf4c1a8 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 8e176b69ac 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 1d68ef4217 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml edbbc9d10e 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py e7e92ec985 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py f6b676b65e 


Diff: https://reviews.apache.org/r/62866/diff/2/

Changes: https://reviews.apache.org/r/62866/diff/1-2/


Testing
-------

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy