You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/15 21:54:46 UTC
[GitHub] [incubator-mxnet] sxjscience opened a new pull request #18076:
[Numpy Extension] Add stop_gradient to npx
sxjscience opened a new pull request #18076: [Numpy Extension] Add stop_gradient to npx
URL: https://github.com/apache/incubator-mxnet/pull/18076
## Description ##
`stop_gradient` is a very important for constructing deep learning models. Now we can use `mx.npx.stop_gradient(x)` for this purpose.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] npx.stop_gradient, tests
## Comments ##
We can not use `detach()` because there is no symbolic equivalent to this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18076: [Numpy
Extension] Add stop_gradient to npx
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18076: [Numpy Extension] Add stop_gradient to npx
URL: https://github.com/apache/incubator-mxnet/pull/18076#issuecomment-614299608
Hey @sxjscience , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, website, centos-cpu, miscellaneous, clang, windows-gpu, centos-gpu, unix-gpu, windows-cpu, edge, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #18076: [Numpy
Extension] Add stop_gradient to npx
Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #18076: [Numpy Extension] Add stop_gradient to npx
URL: https://github.com/apache/incubator-mxnet/pull/18076#issuecomment-614405728
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18076: [Numpy
Extension] Add stop_gradient to npx
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18076: [Numpy Extension] Add stop_gradient to npx
URL: https://github.com/apache/incubator-mxnet/pull/18076#issuecomment-614405758
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] haojin2 merged pull request #18076: [Numpy
Extension] Add stop_gradient to npx
Posted by GitBox <gi...@apache.org>.
haojin2 merged pull request #18076: [Numpy Extension] Add stop_gradient to npx
URL: https://github.com/apache/incubator-mxnet/pull/18076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services