[GitHub] [dubbo] horizonzy commented on a change in pull request #8320: Compatible with nacos grouping via group

[GitBox <gi...@apache.org>]

horizonzy commented on a change in pull request #8320:
URL: https://github.com/apache/dubbo/pull/8320#discussion_r677950894



##########
File path: dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/util/NacosNamingServiceUtils.java
##########
@@ -91,7 +93,9 @@ public static ServiceInstance toServiceInstance(Instance instance) {
      * @since 2.7.5
      */
     public static String getGroup(URL connectionURL) {
-        return connectionURL.getParameter("nacos.group", DEFAULT_GROUP);
+        // Compatible with nacos grouping via group.
+        String group = connectionURL.getParameter(GROUP_KEY, DEFAULT_GROUP);

Review comment:
       Use `dubbo` as the default group will be better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org