You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Venkat Ranganathan <n....@live.com> on 2015/07/16 07:28:50 UTC

Re: Review Request 33443: FALCON-1102: Gather data transfer detail of replication job submitted from HDFS recipe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33443/#review91864
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 408)
<https://reviews.apache.org/r/33443/#comment145549>

    Make sure you use the configuration with HA/security information here.


- Venkat Ranganathan


On April 22, 2015, 10:24 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33443/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 10:24 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1102
>     https://issues.apache.org/jira/browse/FALCON-1102
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1102: Gather data transfer detail of replication job submitted from HDFS recipe
> 
> 
> Diffs
> -----
> 
>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml 145d489 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java 2288443 
>   common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java 0a77bf1 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java 0a8be64 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 53ef5de 
>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 11d27fe 
>   replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java a8cc7e7 
> 
> Diff: https://reviews.apache.org/r/33443/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Re: Review Request 33443: FALCON-1102: Gather data transfer detail of replication job submitted from HDFS recipe

Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.

> On July 16, 2015, 5:28 a.m., Venkat Ranganathan wrote:
> >

Thanks, Venkat for the your comment.


> On July 16, 2015, 5:28 a.m., Venkat Ranganathan wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java, line 411
> > <https://reviews.apache.org/r/33443/diff/1/?file=939668#file939668line411>
> >
> >     Make sure you use the configuration with HA/security information here.

Venkat, I have checked other similar FS initialization in WorkflowExecutionContext class, even that is not using configuration with HA/security. Please suggest.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33443/#review91864
-----------------------------------------------------------


On April 22, 2015, 5:24 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33443/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 5:24 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1102
>     https://issues.apache.org/jira/browse/FALCON-1102
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1102: Gather data transfer detail of replication job submitted from HDFS recipe
> 
> 
> Diffs
> -----
> 
>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml 145d489 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java 2288443 
>   common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java 0a77bf1 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java 0a8be64 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 53ef5de 
>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 11d27fe 
>   replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java a8cc7e7 
> 
> Diff: https://reviews.apache.org/r/33443/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>