You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/06 06:59:23 UTC

[GitHub] ptrendx commented on a change in pull request #7732: Update optimizer.py

ptrendx commented on a change in pull request #7732: Update optimizer.py
URL: https://github.com/apache/incubator-mxnet/pull/7732#discussion_r137185150
 
 

 ##########
 File path: python/mxnet/optimizer.py
 ##########
 @@ -979,8 +979,9 @@ def sync_state_context(self, state, context):
     def set_states(self, states):
         """Sets updater states."""
         states = pickle.loads(states)
-        if isinstance(states, tuple) and len(states) == 2:
-            self.states, self.optimizer = states
+        if isinstance(states, dict):
 
 Review comment:
   Ohhhh. Ok, I got confused as well - any particular state may be a tuple, but states is dictionary of them. Sorry for that.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services