You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/06/07 22:41:22 UTC
[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7107
Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls
......................................................................
IMPALA-5455: test infra: propagate --cm-port, add --use-tls
This patch propagates the --cm-port option to the CM API when creating a
CM ApiResource. It also adds a new flag, --use-tls, also propagated.
Both are used to contact a CM that has TLS enabled.
Reference:
https://cloudera.github.io/cm_api/epydoc/5.4.0/cm_api.api_client.ApiResource-class.html#__init__
Testing:
Connected both to TLS-disabled and TLS-enabled CM instances. Before this
patch, we would fail hard when trying to talk to the TLS-enabled CM
instance.
Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
---
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/7107/1
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7107/1/tests/comparison/cli_options.py
File tests/comparison/cli_options.py:
PS1, Line 146: '--cm-port', default=7180, type=int, metavar='port number',
: help='The port of the CM server. Use 7183 with TLS enabled')
I've never actually seen CM use non-standard ports, i.e. never something besides 7180/7183, and I used to work on CM. I wonder if we should bother with this flag or just set the port based on --use-tls. I'm saying this because it'd be nice we we didn't have to specify it. Perhaps fancier: it'd be nicer if this was only to specify non-std ports, so if you don't specify it then you get 7180/7183.
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................
Patch Set 2:
(1 comment)
Thanks for the review, Matt. Good idea. Please see patch set 2.
http://gerrit.cloudera.org:8080/#/c/7107/1/tests/comparison/cli_options.py
File tests/comparison/cli_options.py:
PS1, Line 146: help='The host name of the CM server.')
: # IMPALA-5455: --cm-port defaults to None so that --use-tls can
> I've never actually seen CM use non-standard ports, i.e. never something be
Done
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................
Patch Set 2: Code-Review+2
nice, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7107
to look at the new patch set (#2).
Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................
IMPALA-5455: test infra: default --cm-port based on --use-tls
This patch sets the default --cm-port (for the CM ApiResource
initialization) based on a new flag, --use-tls, which enables test infra
to talk to CM clusters with TLS enabled. It is still possible to set a
port override, but in general it will not be needed.
Reference:
https://cloudera.github.io/cm_api/epydoc/5.4.0/cm_api.api_client.ApiResource-class.html#__init__
Testing:
Connected both to TLS-disabled and TLS-enabled CM instances. Before this
patch, we would fail hard when trying to talk to the TLS-enabled CM
instance.
Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
---
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
2 files changed, 31 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/7107/2
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................
IMPALA-5455: test infra: default --cm-port based on --use-tls
This patch sets the default --cm-port (for the CM ApiResource
initialization) based on a new flag, --use-tls, which enables test infra
to talk to CM clusters with TLS enabled. It is still possible to set a
port override, but in general it will not be needed.
Reference:
https://cloudera.github.io/cm_api/epydoc/5.4.0/cm_api.api_client.ApiResource-class.html#__init__
Testing:
Connected both to TLS-disabled and TLS-enabled CM instances. Before this
patch, we would fail hard when trying to talk to the TLS-enabled CM
instance.
Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Reviewed-on: http://gerrit.cloudera.org:8080/7107
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
2 files changed, 31 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/701/
--
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No