You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/15 18:14:11 UTC
Re: Review Request 60625: Normalize file separation characters on
Windows when building path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60625/#review182976
-----------------------------------------------------------
3rdparty/stout/include/stout/path.hpp
Line 146 (original), 146-152 (patched)
<https://reviews.apache.org/r/60625/#comment258951>
I don't like that this is duplicating logic.
Moreover, this points out to me that perhaps `paths::uri` should have its logic split.
`paths::normalize` could handle the `\` -> `/` conversion (also allowing us to later handle edge cases), and then could be used here transparently.
Then `paths::uri` could dump `bool addprefix` and just idempotently prepend `file://` to a normalized path.
- Andrew Schwartzmeyer
On July 3, 2017, 12:33 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60625/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 12:33 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Normalize file separation characters on Windows when building path.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp 6ee3a44cd6a878fe383aa68df40b82857b93d0b4
>
>
> Diff: https://reviews.apache.org/r/60625/diff/1/
>
>
> Testing
> -------
>
> See upstream
>
>
> Thanks,
>
> Jeff Coffler
>
>