You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/11 07:12:53 UTC

[GitHub] [ignite] ibessonov commented on a change in pull request #8554: IGNITE-13101 Fixed uncompleted futures leak on node stop in distributed metastorage.

ibessonov commented on a change in pull request #8554:
URL: https://github.com/apache/ignite/pull/8554#discussion_r540736487



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java
##########
@@ -1070,6 +1125,31 @@ else if (!isClient && ver.id() > 0) {
         return fut;
     }
 
+    /** */
+    private GridFutureAdapter<Boolean> validateBeforeWrite(String key) throws IgniteCheckedException {
+        boolean supported;
+
+        try {
+            supported = isSupported(ctx);

Review comment:
       Every component does this, changing the approach is out of the scope. And yes, older node can enter the cluster sometimes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org