[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32404: [SPARK-35278][SQL] Invoke should find the method with correct number of parameters

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #32404:
URL: https://github.com/apache/spark/pull/32404#discussion_r623660010



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -325,7 +325,9 @@ case class Invoke(
 
   @transient lazy val method = targetObject.dataType match {
     case ObjectType(cls) =>
-      val m = cls.getMethods.find(_.getName == encodedFunctionName)
+      val m = cls.getMethods.find { m =>
+        m.getName == encodedFunctionName && m.getParameterCount == arguments.length

Review comment:
       It looks like a very ancient bug from Spark 1.x.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org