[GitHub] [spark] srowen commented on a change in pull request #24609: [SPARK-27715][SQL] SQL query details in UI dose not show in correct format.

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24609: [SPARK-27715][SQL] SQL query details in UI dose not show in correct format.
URL: https://github.com/apache/spark/pull/24609#discussion_r284284384
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ##########
 @@ -388,7 +388,7 @@ private[ui] class ExecutionPagedTable(
         +details
       </span> ++
       <div class="stage-details collapsed">
-        <pre>{execution.description}<br></br>{execution.details}</pre>
+        <pre>{Unparsed(execution.description)}<br></br>{execution.details}</pre>
 
 Review comment:
   It makes some sense. My only paranoid worry is that this opens up some type of XSS attack... can a user control the execution description? we'd render the raw HTML. Instead, can we get HTML out of the description? I don't see why it would have that to begin with.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org