[GitHub] [airflow] vincbeck commented on pull request #33901: Fix inheritance chain in security manager

["vincbeck (via GitHub)" <gi...@apache.org>]

vincbeck commented on PR #33901:
URL: https://github.com/apache/airflow/pull/33901#issuecomment-1699663179

   > > The idea of modules I introduced in `FabAirflowSecurityManagerOverride` was to avoid to build a big monster class very hard to maintain, so I split it in multiple modules.
   > 
   > BTW, I'm wondering if this isn't causing more harm than good. A big file is not necessarily hard to maintain, and I'd argue it's actually harder to maintain code that's spread over 3 different files. Inheritance also comes with extra features that we don't want here. For instance, defining the same method/property/field in 2 files would result in one overriding the other rather than an error.
   
   If you think this is better without these modules, let's go then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org