You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ph...@apache.org on 2018/08/16 20:21:20 UTC
impala git commit: IMPALA-7455: Exclude another log4j artifact.
Repository: impala
Updated Branches:
refs/heads/master 864be3e60 -> 59435fe0a
IMPALA-7455: Exclude another log4j artifact.
log4j-1.2-api-2.8.2.jar is the "log4j2 bridge for log4j 1.2 api", and,
if it is included on the classpath before log4j-1.2.17.jar, frontend
logging doesn't work. This results in tests that look for logs in the
frontend (like test_disable_catalog_data_ops and
test_jvm_pause_monitor_logs_entries) failing.
Interestingly, this is possible because the sorting of
shell globs differs depending on the locale settings. To wit:
$ LC_ALL=en_US.UTF-8 bash -c 'echo fe/target/dependency/*' | tr ' ' '\n' | grep log4j
fe/target/dependency/log4j-1.2.17.jar
fe/target/dependency/log4j-1.2-api-2.8.2.jar
fe/target/dependency/log4j-api-2.8.2.jar
fe/target/dependency/log4j-core-2.8.2.jar
fe/target/dependency/log4j-web-2.8.2.jar
fe/target/dependency/slf4j-log4j12-1.7.25.jar
$ LC_ALL=C bash -c 'echo fe/target/dependency/*' | tr ' ' '\n' | grep log4j
fe/target/dependency/log4j-1.2-api-2.8.2.jar
fe/target/dependency/log4j-1.2.17.jar
fe/target/dependency/log4j-api-2.8.2.jar
fe/target/dependency/log4j-core-2.8.2.jar
fe/target/dependency/log4j-web-2.8.2.jar
fe/target/dependency/slf4j-log4j12-1.7.25.jar
Change-Id: Ibd32be96cd3d668a77abaff4807963155449c95b
Reviewed-on: http://gerrit.cloudera.org:8080/11247
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/59435fe0
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/59435fe0
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/59435fe0
Branch: refs/heads/master
Commit: 59435fe0a9237eb4772eff10b56840820d5c38f8
Parents: 864be3e
Author: Philip Zeyliger <ph...@cloudera.com>
Authored: Wed Aug 15 19:08:25 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu Aug 16 19:51:22 2018 +0000
----------------------------------------------------------------------
fe/pom.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/59435fe0/fe/pom.xml
----------------------------------------------------------------------
diff --git a/fe/pom.xml b/fe/pom.xml
index ebb415e..a120536 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -303,6 +303,11 @@ under the License.
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</exclusion>
+ <!-- Similarly, avoid pulling in the "Log4j 1.2 Bridge" -->
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </exclusion>
<!-- https://issues.apache.org/jira/browse/HADOOP-14903 -->
<exclusion>
<groupId>net.minidev</groupId>
@@ -321,6 +326,11 @@ under the License.
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</exclusion>
+ <!-- Similarly, avoid pulling in the "Log4j 1.2 Bridge" -->
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </exclusion>
<!-- https://issues.apache.org/jira/browse/HADOOP-14903 -->
<exclusion>
<groupId>net.minidev</groupId>
@@ -695,6 +705,7 @@ under the License.
<bannedDependencies>
<excludes>
<exclude>org.apache.logging.log4j:log4j-slf4j-impl</exclude>
+ <exclude>org.apache.logging.log4j:log4j-1.2-api</exclude>
<!-- Assert that we only use artifacts from only the specified
version of these components. -->
<exclude>org.apache.hadoop:*</exclude>