You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/18 04:17:51 UTC
[GitHub] [spark] Yikun opened a new pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Yikun opened a new pull request #34939:
URL: https://github.com/apache/spark/pull/34939
### What changes were proposed in this pull request?
This patch aims to upgrade `kubernetes-client` from 5.10.1 to 5.11.0
### Why are the changes needed?
This will bring the several bug fixes and improvements (such as Volcano/Istio support), see more in:
- https://github.com/fabric8io/kubernetes-client/releases/tag/v5.11.0
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997148225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50824/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997176435
**[Test build #146354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146354/testReport)** for PR 34939 at commit [`4811c24`](https://github.com/apache/spark/commit/4811c249bc307dfca763911c9f9dd4ecffeefb07).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997140979
There are some breaking changes in the API of k8s-cli v5.11, looks like it breaks to **create httpclient with custom dispatcher** [like what we did here](https://github.com/apache/spark/blob/19227983e91a54b5f27ade6412dad1088dfcba9e/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala#L110) .
So we need to do some changes to make it work.
issue: https://github.com/fabric8io/kubernetes-client/issues/3663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997141852
**[Test build #146350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146350/testReport)** for PR 34939 at commit [`5b32fdf`](https://github.com/apache/spark/commit/5b32fdf024e9c388890a0bd546988b029801890c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997673460
**[Test build #146389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146389/testReport)** for PR 34939 at commit [`ecd15cb`](https://github.com/apache/spark/commit/ecd15cb081c7691b750e37e815e4bc52dac873f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997182656
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.2
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1020724269
@dongjoon-hyun Sure, will upgrade soon. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.12.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34939:
URL: https://github.com/apache/spark/pull/34939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997332939
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146372/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997639341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146386/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997705617
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50864/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997764248
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50864/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997806031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146389/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997350447
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146373/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997148225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50824/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997159852
> Is it for Volcano?
@dongjoon-hyun Yes. The [volcano extesnion](https://github.com/fabric8io/kubernetes-client/tree/master/extensions/volcano) was introduced in k8s-cli v5.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997337015
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50847/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997196017
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997606035
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50861/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997764207
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50864/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997326701
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997143803
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50824/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997211427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50835/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997209149
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50835/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997328145
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997350447
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146373/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34939:
URL: https://github.com/apache/spark/pull/34939#discussion_r772055958
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -68,6 +69,8 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
val clientCertFile = sparkConf
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
+ // TODO(SPARK-37687): clean up direct usage of OkHttpClient, see also:
Review comment:
Here are some backgroud on this note (also add the jira: [SPARK-37687](https://issues.apache.org/jira/browse/SPARK-37687)):
- There are [some problems (such as IPV6 based cluster support)](https://github.com/fabric8io/kubernetes-client/issues/2632) on okhttpclient v3, but it's a little bit diffcult to upgrade to v4 [1]
- Kubernetes client are also consider to[ support other clients](https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997402993) rather than single okhttpclient.
- Kubernetes client[ add a abstract layer](https://github.com/fabric8io/kubernetes-client/issues/3547) to support variety httpclient, okhttp client as one of supported http clients.
So, we'd better to consider to cleanup okhttpclient direct usage and use the httpclient which kubernetes client diret supported to reduce the potential risk in future upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997583381
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50861/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997211420
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50835/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997343749
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50847/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997182083
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997613126
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50861/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997764248
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50864/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997649373
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997555454
cc @dongjoon-hyun @holdenk @attilapiros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.12.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34939:
URL: https://github.com/apache/spark/pull/34939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997159852
> Is it for Volcano?
@dongjoon-hyun Yes~The volcano extesnion was introduced in k8s-cli v5.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997182659
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997218637
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997613126
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50861/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997328145
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997801563
**[Test build #146389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146389/testReport)** for PR 34939 at commit [`ecd15cb`](https://github.com/apache/spark/commit/ecd15cb081c7691b750e37e815e4bc52dac873f0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997142621
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-999953272
@dongjoon-hyun I can understand your concerns for sure, it makes sense to wait for next release to avoid pontential flaky factor of breaking changes.
But there is one thing I need to clarify, even in the next version we will still face these changes to make okhttpclient work. BTW, these changes are changed according to https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997214403 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-999953272
@dongjoon-hyun Thanks for review. I can understand your concerns for sure, it makes sense to wait for next release to avoid pontential flaky factor of breaking changes.
But there is one thing I need to clarify, even in the next version we will still face these changes to make okhttpclient work. BTW, these changes are changed according to https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997214403 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997333119
**[Test build #146373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146373/testReport)** for PR 34939 at commit [`5b1ab40`](https://github.com/apache/spark/commit/5b1ab40e4b80bcbcf5205825a4ce42917d423ecc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997332939
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146372/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997639341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146386/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997673460
**[Test build #146389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146389/testReport)** for PR 34939 at commit [`ecd15cb`](https://github.com/apache/spark/commit/ecd15cb081c7691b750e37e815e4bc52dac873f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997648029
cc @dongjoon-hyun @holdenk @attilapiros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997142611
**[Test build #146350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146350/testReport)** for PR 34939 at commit [`5b32fdf`](https://github.com/apache/spark/commit/5b32fdf024e9c388890a0bd546988b029801890c).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997217823
**[Test build #146360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146360/testReport)** for PR 34939 at commit [`6d7451d`](https://github.com/apache/spark/commit/6d7451d47ff855d386bddff5427564fa07c7aa7a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997218637
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997318973
**[Test build #146372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146372/testReport)** for PR 34939 at commit [`5b1ab40`](https://github.com/apache/spark/commit/5b1ab40e4b80bcbcf5205825a4ce42917d423ecc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34939:
URL: https://github.com/apache/spark/pull/34939#discussion_r772055958
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -68,6 +69,8 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
val clientCertFile = sparkConf
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
+ // TODO(SPARK-37687): clean up direct usage of OkHttpClient, see also:
Review comment:
Here are some backgroud on this note (also add the jira: [SPARK-37687](https://issues.apache.org/jira/browse/SPARK-37687)):
- There are [some problems (such as IPV6 based cluster support)](https://github.com/fabric8io/kubernetes-client/issues/2632) on okhttpclient v3, but it's a little bit diffcult to upgrade to v4.
- Kubernetes client are also consider to[ support other clients](https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997402993) rather than single okhttpclient.
- Kubernetes client[ add a abstract layer](https://github.com/fabric8io/kubernetes-client/issues/3547) to support variety httpclient, okhttp client as one of supported http clients.
So, we'd better to consider to cleanup okhttpclient direct usage and use the httpclient which kubernetes client diret supported to reduce the potential risk in future upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997198370
**[Test build #146360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146360/testReport)** for PR 34939 at commit [`6d7451d`](https://github.com/apache/spark/commit/6d7451d47ff855d386bddff5427564fa07c7aa7a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997211427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50835/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997343749
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50847/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997198370
**[Test build #146360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146360/testReport)** for PR 34939 at commit [`6d7451d`](https://github.com/apache/spark/commit/6d7451d47ff855d386bddff5427564fa07c7aa7a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997176435
**[Test build #146354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146354/testReport)** for PR 34939 at commit [`4811c24`](https://github.com/apache/spark/commit/4811c249bc307dfca763911c9f9dd4ecffeefb07).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997182659
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50828/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997347848
**[Test build #146373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146373/testReport)** for PR 34939 at commit [`5b1ab40`](https://github.com/apache/spark/commit/5b1ab40e4b80bcbcf5205825a4ce42917d423ecc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997333119
**[Test build #146373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146373/testReport)** for PR 34939 at commit [`5b1ab40`](https://github.com/apache/spark/commit/5b1ab40e4b80bcbcf5205825a4ce42917d423ecc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1020741361
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997631843
**[Test build #146386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146386/testReport)** for PR 34939 at commit [`ecd15cb`](https://github.com/apache/spark/commit/ecd15cb081c7691b750e37e815e4bc52dac873f0).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997567567
**[Test build #146386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146386/testReport)** for PR 34939 at commit [`ecd15cb`](https://github.com/apache/spark/commit/ecd15cb081c7691b750e37e815e4bc52dac873f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997806031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146389/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] klaus-xiong commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
klaus-xiong commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1000130419
@Yikun Do you have a time line for the 'Cleanup direct usage of OkHttpClient' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1000214296
@klaus-xiong I think the deadline depends on when new better httpclient to replace okhttpclient are supported in k8s client, and also this replacement meet the requirement of Spark on K8S.
It bring some potential issue when k8s-cli to stop okhttpclient support (as https://github.com/fabric8io/kubernetes-client/issues/3547 mentioned, OkHttpClient has some known issue and it's not easy to upgrade OkHttpClient), it may not be a good choice if we still keep the direct OkHttpClient usage in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1000214296
@klaus-xiong I think the deadline depends on when the new other httpclient to replace okhttpclient are supported in k8s client, and also this replacement meet the requirement of Spark on K8S.
It bring some potential issue when k8s-cli to stop okhttpclient support (as https://github.com/fabric8io/kubernetes-client/issues/3547 mentioned, OkHttpClient has some known issue and it's not easy to upgrade OkHttpClient), it may not be a good choice if we still keep the direct OkHttpClient usage in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997194120
**[Test build #146354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146354/testReport)** for PR 34939 at commit [`4811c24`](https://github.com/apache/spark/commit/4811c249bc307dfca763911c9f9dd4ecffeefb07).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997196017
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997322494
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997331559
**[Test build #146372 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146372/testReport)** for PR 34939 at commit [`5b1ab40`](https://github.com/apache/spark/commit/5b1ab40e4b80bcbcf5205825a4ce42917d423ecc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997318973
**[Test build #146372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146372/testReport)** for PR 34939 at commit [`5b1ab40`](https://github.com/apache/spark/commit/5b1ab40e4b80bcbcf5205825a4ce42917d423ecc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997330678
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997343574
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50847/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34939:
URL: https://github.com/apache/spark/pull/34939#discussion_r772055958
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -68,6 +69,8 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
val clientCertFile = sparkConf
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
+ // TODO(SPARK-37687): clean up direct usage of OkHttpClient, see also:
Review comment:
Here are some backgroud on this note (also add the jira: [SPARK-37687](https://issues.apache.org/jira/browse/SPARK-37687)):
- There are [some problems (such as IPV6 based cluster support)](https://github.com/fabric8io/kubernetes-client/issues/2632) on okhttpclient v3, but it's a little bit diffcult to upgrade to v4 [1]
- Kubernetes client are also consider to[ support other clients](https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997402993) rather than single okhttpclient.
- Kubernetes client[ add a abstract layer](https://github.com/fabric8io/kubernetes-client/issues/3547) to support variety httpclient, okhttp client as one of supported http clients.
So, we better to consider to cleanup okhttpclient direct usage and use the httpclient which kubernetes client diret supported to reduce the potential risk in future upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997555454
cc @dongjoon-hyun @holdenk @attilapiros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997567567
**[Test build #146386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146386/testReport)** for PR 34939 at commit [`ecd15cb`](https://github.com/apache/spark/commit/ecd15cb081c7691b750e37e815e4bc52dac873f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997141852
**[Test build #146350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146350/testReport)** for PR 34939 at commit [`5b32fdf`](https://github.com/apache/spark/commit/5b32fdf024e9c388890a0bd546988b029801890c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][Build] Upgrade kubernetes-client to 5.11.0.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-997142621
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34939:
URL: https://github.com/apache/spark/pull/34939#discussion_r772055958
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -68,6 +69,8 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
val clientCertFile = sparkConf
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
+ // TODO(SPARK-37687): clean up direct usage of OkHttpClient, see also:
Review comment:
Here are some backgroud on this note (also add the jira: [SPARK-37687](https://issues.apache.org/jira/browse/SPARK-37687)):
- There are [some problems (such as IPV6 based cluster support)](https://github.com/fabric8io/kubernetes-client/issues/2632) on okhttpclient v3, but it's a little bit diffcult to upgrade to v4.
- Kubernetes client are also consider to[ support other clients](https://github.com/fabric8io/kubernetes-client/issues/3663#issuecomment-997402993) rather than single okhttpclient.
- Kubernetes client[ add a abstract layer](https://github.com/fabric8io/kubernetes-client/issues/3547) to support variety httpclient, okhttp client as one of supported http clients.
So, we'd better to consider to cleanup okhttpclient direct usage in some right time and use the httpclient which kubernetes client diret supported to reduce the potential risk in future upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.2
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1020724269
@dongjoon-hyun Sure, will upgrade soon. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34939:
URL: https://github.com/apache/spark/pull/34939#issuecomment-1020741361
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org