You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "szymon-czapracki (via GitHub)" <gi...@apache.org> on 2024/05/14 14:50:55 UTC
[PR] BASS fixes. [mynewt-nimble]
szymon-czapracki opened a new pull request, #1779:
URL: https://github.com/apache/mynewt-nimble/pull/1779
Fixed characteristic properties.
Changed naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BASS & GATT fixes. [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1779:
URL: https://github.com/apache/mynewt-nimble/pull/1779#discussion_r1601565822
##########
nimble/host/include/host/ble_gatt.h:
##########
@@ -121,49 +121,49 @@ struct ble_hs_cfg;
* @{
*/
-/** GATT Characteristic Flag: Broadcast. */
+/** GATT Characteristic Flag: Broadcast property. */
#define BLE_GATT_CHR_F_BROADCAST 0x0001
-/** GATT Characteristic Flag: Read. */
+/** GATT Characteristic Flag: Read property. */
#define BLE_GATT_CHR_F_READ 0x0002
-/** GATT Characteristic Flag: Write without Response. */
+/** GATT Characteristic Flag: Write without Response property. */
#define BLE_GATT_CHR_F_WRITE_NO_RSP 0x0004
-/** GATT Characteristic Flag: Write. */
+/** GATT Characteristic Flag: Write property. */
#define BLE_GATT_CHR_F_WRITE 0x0008
-/** GATT Characteristic Flag: Notify. */
+/** GATT Characteristic Flag: Notify property. */
#define BLE_GATT_CHR_F_NOTIFY 0x0010
-/** GATT Characteristic Flag: Indicate. */
+/** GATT Characteristic Flag: Indicate property. */
#define BLE_GATT_CHR_F_INDICATE 0x0020
-/** GATT Characteristic Flag: Authenticated Signed Writes. */
+/** GATT Characteristic Flag: Authenticated Signed Writes property. */
#define BLE_GATT_CHR_F_AUTH_SIGN_WRITE 0x0040
-/** GATT Characteristic Flag: Reliable Writes. */
Review Comment:
reliable writes are (extended) property, not permission
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BASS & GATT fixes. [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1779:
URL: https://github.com/apache/mynewt-nimble/pull/1779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BASS fixes. [mynewt-nimble]
Posted by "szymon-czapracki (via GitHub)" <gi...@apache.org>.
szymon-czapracki commented on PR #1779:
URL: https://github.com/apache/mynewt-nimble/pull/1779#issuecomment-2110450920
@sjanc @KKopyscinski FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BASS & GATT fixes. [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub)" <gi...@apache.org>.
MariuszSkamra commented on PR #1779:
URL: https://github.com/apache/mynewt-nimble/pull/1779#issuecomment-2115141341
BASS related changes LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org