You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/04/09 11:36:39 UTC

[GitHub] [calcite] zabetak opened a new pull request #2389: [CALCITE-4570] Always validate preconditions in Filter/Correlate/Snapshot expressions when assertions are enabled

zabetak opened a new pull request #2389:
URL: https://github.com/apache/calcite/pull/2389


   Validate preconditions in the constructor of Filter, Correlate, and
   Snapshot regardless if CalciteSystemProperty.DEBUG is enabled or not.
   To avoid the performance overhead in production the assertions can be
   disabled as it usually happens.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2389: [CALCITE-4570] Always validate preconditions in Filter/Correlate/Snapshot expressions when assertions are enabled

Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2389:
URL: https://github.com/apache/calcite/pull/2389#issuecomment-816699221


   LGTM.
   Maybe we could use this PR to remove the `assert isValid(Litmus.THROW, null);` from `LogicalFilter` constructor which seems redundant, since it will be already validated by `Filter` when it calls `super`. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] zabetak merged pull request #2389: [CALCITE-4570] Always validate preconditions in Filter/Correlate/Snapshot expressions when assertions are enabled

Posted by GitBox <gi...@apache.org>.
zabetak merged pull request #2389:
URL: https://github.com/apache/calcite/pull/2389


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] zabetak commented on pull request #2389: [CALCITE-4570] Always validate preconditions in Filter/Correlate/Snapshot expressions when assertions are enabled

Posted by GitBox <gi...@apache.org>.
zabetak commented on pull request #2389:
URL: https://github.com/apache/calcite/pull/2389#issuecomment-816834031


   > LGTM.
   > Maybe we could use this PR to remove the `assert isValid(Litmus.THROW, null);` from `LogicalFilter` constructor which seems redundant, since it will be already validated by `Filter` when it calls `super`. WDYT?
   
   Good catch @rubenada , totally makes sense! Thanks for taking a look :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org