You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "John Costello (JIRA)" <ji...@apache.org> on 2009/01/27 19:52:59 UTC
[jira] Created: (DIRMINA-658) BufferedWriteFilter does not pass
session closed or exception caught events up the filter chain
BufferedWriteFilter does not pass session closed or exception caught events up the filter chain
------------------------------------------------------------------------------------------------
Key: DIRMINA-658
URL: https://issues.apache.org/jira/browse/DIRMINA-658
Project: MINA
Issue Type: Bug
Components: Filter
Affects Versions: 2.0.0-M4
Reporter: John Costello
BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-658) BufferedWriteFilter does not pass
session closed or exception caught events up the filter chain
Posted by "John Costello (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Costello updated DIRMINA-658:
----------------------------------
Description:
BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
Patch:
Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
===================================================================
--- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (revision 738176)
+++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (working copy)
@@ -243,6 +243,7 @@
public void exceptionCaught(NextFilter nextFilter, IoSession session,
Throwable cause) throws Exception {
free(session);
+ nextFilter.exceptionCaught(session, cause);
}
/**
@@ -252,5 +253,6 @@
public void sessionClosed(NextFilter nextFilter, IoSession session)
throws Exception {
free(session);
+ nextFilter.sessionClosed(session);
}
}
\ No newline at end of file
was:BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
> BufferedWriteFilter does not pass session closed or exception caught events up the filter chain
> ------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-658
> URL: https://issues.apache.org/jira/browse/DIRMINA-658
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 2.0.0-M4
> Reporter: John Costello
> Attachments: Test.java
>
>
> BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
> Patch:
> Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> ===================================================================
> --- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (revision 738176)
> +++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (working copy)
> @@ -243,6 +243,7 @@
> public void exceptionCaught(NextFilter nextFilter, IoSession session,
> Throwable cause) throws Exception {
> free(session);
> + nextFilter.exceptionCaught(session, cause);
> }
>
> /**
> @@ -252,5 +253,6 @@
> public void sessionClosed(NextFilter nextFilter, IoSession session)
> throws Exception {
> free(session);
> + nextFilter.sessionClosed(session);
> }
> }
> \ No newline at end of file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-658) BufferedWriteFilter does not pass
session closed or exception caught events up the filter chain
Posted by "John Costello (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Costello updated DIRMINA-658:
----------------------------------
Attachment: Test.java
Attached a test app that is supposed to exit once the session closed event is received, but instead hangs
> BufferedWriteFilter does not pass session closed or exception caught events up the filter chain
> ------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-658
> URL: https://issues.apache.org/jira/browse/DIRMINA-658
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 2.0.0-M4
> Reporter: John Costello
> Attachments: Test.java
>
>
> BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-658) BufferedWriteFilter does not pass
session closed or exception caught events up the filter chain
Posted by "Edouard De Oliveira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edouard De Oliveira updated DIRMINA-658:
----------------------------------------
Fix Version/s: 2.0.0-RC1
Assignee: Edouard De Oliveira
i shall investigate & test this but I believe you're right
> BufferedWriteFilter does not pass session closed or exception caught events up the filter chain
> ------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-658
> URL: https://issues.apache.org/jira/browse/DIRMINA-658
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 2.0.0-M4
> Reporter: John Costello
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-RC1
>
> Attachments: Test.java
>
>
> BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
> Patch:
> Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> ===================================================================
> --- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (revision 738176)
> +++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (working copy)
> @@ -243,6 +243,7 @@
> public void exceptionCaught(NextFilter nextFilter, IoSession session,
> Throwable cause) throws Exception {
> free(session);
> + nextFilter.exceptionCaught(session, cause);
> }
>
> /**
> @@ -252,5 +253,6 @@
> public void sessionClosed(NextFilter nextFilter, IoSession session)
> throws Exception {
> free(session);
> + nextFilter.sessionClosed(session);
> }
> }
> \ No newline at end of file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-658) BufferedWriteFilter does not pass
session closed or exception caught events up the filter chain
Posted by "Edouard De Oliveira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edouard De Oliveira resolved DIRMINA-658.
-----------------------------------------
Resolution: Fixed
Fixed
Thx for the detailed report
> BufferedWriteFilter does not pass session closed or exception caught events up the filter chain
> ------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-658
> URL: https://issues.apache.org/jira/browse/DIRMINA-658
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 2.0.0-M4
> Reporter: John Costello
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-RC1
>
> Attachments: Test.java
>
>
> BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
> Patch:
> Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> ===================================================================
> --- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (revision 738176)
> +++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (working copy)
> @@ -243,6 +243,7 @@
> public void exceptionCaught(NextFilter nextFilter, IoSession session,
> Throwable cause) throws Exception {
> free(session);
> + nextFilter.exceptionCaught(session, cause);
> }
>
> /**
> @@ -252,5 +253,6 @@
> public void sessionClosed(NextFilter nextFilter, IoSession session)
> throws Exception {
> free(session);
> + nextFilter.sessionClosed(session);
> }
> }
> \ No newline at end of file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-658) BufferedWriteFilter does not pass
session closed or exception caught events up the filter chain
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRMINA-658.
-------------------------------------
> BufferedWriteFilter does not pass session closed or exception caught events up the filter chain
> ------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-658
> URL: https://issues.apache.org/jira/browse/DIRMINA-658
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 2.0.0-M4
> Reporter: John Costello
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-M5
>
> Attachments: Test.java
>
>
> BufferedWriteFilter does not pass along the session closed or exception caught events up the filter chain. This will cause problems with any application that needs to clean up resources on client disconnect or try to reconnect to a server if it has been disconnected. From looking at the other filters, it doesn't look like this omission was intentional
> Patch:
> Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> ===================================================================
> --- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (revision 738176)
> +++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java (working copy)
> @@ -243,6 +243,7 @@
> public void exceptionCaught(NextFilter nextFilter, IoSession session,
> Throwable cause) throws Exception {
> free(session);
> + nextFilter.exceptionCaught(session, cause);
> }
>
> /**
> @@ -252,5 +253,6 @@
> public void sessionClosed(NextFilter nextFilter, IoSession session)
> throws Exception {
> free(session);
> + nextFilter.sessionClosed(session);
> }
> }
> \ No newline at end of file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.