You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2021/01/05 10:49:58 UTC
[royale-asjs] branch develop updated: jewel-beads: change to use
DispatcherBead in some beads when there's a [Bindable] metadata an
EventDispatcher is required,
so when extending the code we don't have any issue
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 75b225e jewel-beads: change to use DispatcherBead in some beads when there's a [Bindable] metadata an EventDispatcher is required, so when extending the code we don't have any issue
75b225e is described below
commit 75b225ebc67cbd64600f1794165c505e57167783
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Tue Jan 5 11:49:48 2021 +0100
jewel-beads: change to use DispatcherBead in some beads when there's a [Bindable] metadata an EventDispatcher is required, so when extending the code we don't have any issue
---
.../royale/org/apache/royale/jewel/beads/controls/Badge.as | 12 +++++++-----
.../org/apache/royale/jewel/beads/controls/Disabled.as | 2 +-
.../beads/controls/combobox/ComboBoxListCloseOnClick.as | 11 ++++++-----
.../controls/datechooser/DateChooserDateRangeRestriction.as | 9 ++++-----
.../controls/datefield/DateFieldDateRangeRestriction.as | 12 +++++-------
5 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Badge.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Badge.as
index 04d703f..b5a9570 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Badge.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Badge.as
@@ -18,7 +18,7 @@
////////////////////////////////////////////////////////////////////////////////
package org.apache.royale.jewel.beads.controls
{
- import org.apache.royale.core.IBead;
+ import org.apache.royale.core.DispatcherBead;
import org.apache.royale.core.IStrand;
import org.apache.royale.core.UIBase;
import org.apache.royale.jewel.Label;
@@ -36,7 +36,7 @@ package org.apache.royale.jewel.beads.controls
* @playerversion AIR 2.6
* @productversion Royale 0.9.6
*/
- public class Badge implements IBead, IEmphasis
+ public class Badge extends DispatcherBead implements IEmphasis
{
/**
* constructor.
@@ -77,13 +77,15 @@ package org.apache.royale.jewel.beads.controls
* @playerversion AIR 2.6
* @productversion Royale 0.9.6
*/
- public function set strand(value:IStrand):void
+ public override function set strand(value:IStrand):void
{
+ super.strand = value;
+
host = value as UIBase;
COMPILE::JS
{
- host.element.classList.add("visible");
- host.element.classList.add("viewport");
+ host.element.classList.add("visible");
+ host.element.classList.add("viewport");
}
badge.toggleClass("preindex", _preindex);
badge.toggleClass("subindex", _subindex);
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Disabled.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Disabled.as
index 9694ada..b16863c 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Disabled.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/Disabled.as
@@ -96,7 +96,7 @@ package org.apache.royale.jewel.beads.controls
*/
override public function set strand(value:IStrand):void
{
- _strand = value;
+ super.strand = value;
updateHost();
}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/ComboBoxListCloseOnClick.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/ComboBoxListCloseOnClick.as
index 6ec5971..9bffe3e 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/ComboBoxListCloseOnClick.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/ComboBoxListCloseOnClick.as
@@ -18,7 +18,7 @@
////////////////////////////////////////////////////////////////////////////////
package org.apache.royale.jewel.beads.controls.combobox
{
- import org.apache.royale.core.IBead;
+ import org.apache.royale.core.DispatcherBead;
import org.apache.royale.core.IStrand;
import org.apache.royale.core.ValuesManager;
import org.apache.royale.events.IEventDispatcher;
@@ -40,7 +40,7 @@ package org.apache.royale.jewel.beads.controls.combobox
* @playerversion AIR 2.6
* @productversion Royale 0.9.8
*/
- public class ComboBoxListCloseOnClick implements IBead{
+ public class ComboBoxListCloseOnClick extends DispatcherBead {
/**
* constructor.
@@ -55,10 +55,11 @@ package org.apache.royale.jewel.beads.controls.combobox
private var _list:List;
private var comboView:ComboBoxView;
+
+ public override function set strand(value:IStrand):void
+ {
+ super.strand = value;
-
- public function set strand(value:IStrand):void
- {
var comboBox:ComboBox = (value as ComboBox);
comboView = (comboBox.view as ComboBoxView);
var itemRendererClass:Class = ValuesManager.valuesImpl.getValue(comboView.host, "iItemRenderer") as Class;
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datechooser/DateChooserDateRangeRestriction.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datechooser/DateChooserDateRangeRestriction.as
index ed674d7..ac5e864 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datechooser/DateChooserDateRangeRestriction.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datechooser/DateChooserDateRangeRestriction.as
@@ -18,7 +18,7 @@
////////////////////////////////////////////////////////////////////////////////
package org.apache.royale.jewel.beads.controls.datechooser
{
- import org.apache.royale.core.IBead;
+ import org.apache.royale.core.DispatcherBead;
import org.apache.royale.core.IStrand;
import org.apache.royale.events.Event;
import org.apache.royale.events.IEventDispatcher;
@@ -45,7 +45,7 @@ package org.apache.royale.jewel.beads.controls.datechooser
* @playerversion AIR 2.6
* @productversion Royale 0.9.8
*/
- public class DateChooserDateRangeRestriction implements IBead
+ public class DateChooserDateRangeRestriction extends DispatcherBead
{
/**
* constructor.
@@ -105,7 +105,6 @@ package org.apache.royale.jewel.beads.controls.datechooser
}
}
- private var _strand:IStrand;
/**
* @copy org.apache.royale.core.IBead#strand
*
@@ -115,9 +114,9 @@ package org.apache.royale.jewel.beads.controls.datechooser
* @productversion Royale 0.9.8
* @royaleignorecoercion org.apache.royale.events.IEventDispatcher
*/
- public function set strand(value:IStrand):void
+ public override function set strand(value:IStrand):void
{
- _strand = value;
+ super.strand = value;
(_strand as IEventDispatcher).addEventListener("initComplete", handleDateChooserInitComplete);
}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datefield/DateFieldDateRangeRestriction.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datefield/DateFieldDateRangeRestriction.as
index 811c1a2..cdb29a1 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datefield/DateFieldDateRangeRestriction.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datefield/DateFieldDateRangeRestriction.as
@@ -18,14 +18,13 @@
////////////////////////////////////////////////////////////////////////////////
package org.apache.royale.jewel.beads.controls.datefield
{
- import org.apache.royale.core.IBead;
+ import org.apache.royale.core.DispatcherBead;
import org.apache.royale.core.IStrand;
import org.apache.royale.events.Event;
import org.apache.royale.events.IEventDispatcher;
- import org.apache.royale.jewel.beads.itemRenderers.ITextItemRenderer;
- import org.apache.royale.jewel.beads.views.DateFieldView;
import org.apache.royale.jewel.DateChooser;
import org.apache.royale.jewel.beads.controls.datechooser.DateChooserDateRangeRestriction;
+ import org.apache.royale.jewel.beads.views.DateFieldView;
/**
* Disable dates which are outside restriction provided by minDate and maxDate properties
@@ -36,7 +35,7 @@ package org.apache.royale.jewel.beads.controls.datefield
* @playerversion AIR 2.6
* @productversion Royale 0.9.8
*/
- public class DateFieldDateRangeRestriction implements IBead
+ public class DateFieldDateRangeRestriction extends DispatcherBead
{
/**
* constructor.
@@ -96,7 +95,6 @@ package org.apache.royale.jewel.beads.controls.datefield
}
}
- private var _strand:IStrand;
/**
* @copy org.apache.royale.core.IBead#strand
*
@@ -106,9 +104,9 @@ package org.apache.royale.jewel.beads.controls.datefield
* @productversion Royale 0.9.8
* @royaleignorecoercion org.apache.royale.events.IEventDispatcher
*/
- public function set strand(value:IStrand):void
+ public override function set strand(value:IStrand):void
{
- _strand = value;
+ super.strand = value;
(_strand as IEventDispatcher).addEventListener("initComplete", handleDateFieldInitComplete);
}