You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by kjduling <gi...@git.apache.org> on 2016/10/27 15:46:13 UTC
[GitHub] incubator-geode pull request #273: Feature/geode 1983
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/273
Feature/geode 1983
Updated the spring security configuration to support the Swagger2 resources.
Precheckin successful.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1983
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #273: Feature/geode 1983
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/incubator-geode/pull/273
Travis failed with:
* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.
> Format violations were found. Run 'gradlew spotlessApply' to fix them.
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelQueueRemovalMessage.java
geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelQueueRemovalMessageJUnitTest.java
geode-core/src/test/java/org/apache/geode/internal/cache/BucketRegionQueueHelper.java
Have you run precheckin yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #273: Feature/geode 1983
Posted by kjduling <gi...@git.apache.org>.
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/273
Travis is happy now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #273: Feature/geode 1983
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #273: Feature/geode 1983
Posted by kjduling <gi...@git.apache.org>.
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/273
Updated to use SimpleSecurityManager.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #273: Feature/geode 1983
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/273#discussion_r85375614
--- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java ---
@@ -42,6 +44,7 @@
static Properties properties = new Properties() {
{
setProperty(START_DEV_REST_API, "true");
+ setProperty(SECURITY_MANAGER, SampleSecurityManager.class.getName());
--- End diff --
using SamplesecurityManager will require you to use a json file as well. Use SimpleSecurityManager instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #273: Feature/geode 1983
Posted by kjduling <gi...@git.apache.org>.
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/273
I didn't modify those classes. I merged in from develop, which means this code is not formatted correctly in develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---