You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/03/21 13:04:51 UTC
[GitHub] [incubator-uniffle] advancedxy opened a new issue, #750: [Improvement] Fetch Failed related exceptions should have a dedicated RssException class
advancedxy opened a new issue, #750:
URL: https://github.com/apache/incubator-uniffle/issues/750
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
Currently, a lot of exception are all called RssException, which has no distinguish meanings.
When I'm implementing #477, I think we should at least to make fetch fetch exception a dedicated subclass.
### How should we improve?
1. define a new exception class
2. when fetch failed occurred, throw the corresponding exception
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #750: [Improvement] Fetch Failed related exceptions should have a dedicated RssException class
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #750:
URL: https://github.com/apache/incubator-uniffle/issues/750#issuecomment-1478821294
> > Currently, a lot of exception are all called RssException, which has no distinguish meanings.
>
> Thanks for the improvement. There are also many raw use of `RuntimeException` need to be replaced.
Yes, it's definitely worth refactor. Would you mind create an issue for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on issue #750: [Improvement] Fetch Failed related exceptions should have a dedicated RssException class
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on issue #750:
URL: https://github.com/apache/incubator-uniffle/issues/750#issuecomment-1477926547
> Currently, a lot of exception are all called RssException, which has no distinguish meanings.
Thanks for the improvement. There are also many raw use of `RuntimeException` need to be replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] kaijchen closed issue #750: [Improvement] Fetch Failed related exceptions should have a dedicated RssException class
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen closed issue #750: [Improvement] Fetch Failed related exceptions should have a dedicated RssException class
URL: https://github.com/apache/incubator-uniffle/issues/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org