You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/02/27 00:04:57 UTC
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9455
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
In test_column_storage_attributes the column type is also used as
the column name. To ensure the type name is also a valid column
name, the default decimal type is now used.
Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
---
M tests/query_test/test_kudu.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/9455/1
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> When I wen't back and looked at the motivation and code path for this test
Aren't these decimals internally represented with a different number of bytes? Should we make sure the different byte sizes work?
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:26:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
instead of reducing test coverage how about making this a list of (type, name) tuples
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:12:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> Aren't these decimals internally represented with a different number of byt
We should and we do in other tests. I am not sure those sizes really impact the storage_attributes being tested/applied here.
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:35:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 08:51:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
In test_column_storage_attributes the column type is also used as
the column name. To ensure the type name is also a valid column
name, the default decimal type is now used.
Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Reviewed-on: http://gerrit.cloudera.org:8080/9455
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/query_test/test_kudu.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> Aren't these decimals internally represented with a different number of byt
My preference would be to test all the decimal byte sizes since they are represented differently and exercise different code paths. Especially the Kudu/Impala tuple data hand-off is interesting with different byte sizes.
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:32:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> +1
When I wen't back and looked at the motivation and code path for this test I found their is no difference between the 3 decimal sizes when it comes to column storage attributes. Via the api in this case all of them are just "DECIMAL" DataType.
It's worth noting this isn't reducing coverage. I just made a mistake when adding coverage because this test didn't run.
If you feel strongly about testing each decimal "size" I can make the suggested change, but I am not sure it adds a lot of test/validation value.
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:22:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2021/
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 05:03:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> We should and we do in other tests. I am not sure those sizes really impact
The kudu_create.test, kudu_insert.test, kudu_upsert.test, kudu_delete.test queries all exercise the 3 different size representations.
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:38:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1:
(1 comment)
Thanks for jumping on this!
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> instead of reducing test coverage how about making this a list of (type, na
+1
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 00:15:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359
PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \
> The kudu_create.test, kudu_insert.test, kudu_upsert.test, kudu_delete.test
I checked the tests and most of them go through all byte sizes - but not kudu_upsert.test
This patch works for me.
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 05:02:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6584: Fix TestKuduOperations::test column storage attributes
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9455
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945
Gerrit-Change-Number: 9455
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 05:03:03 +0000
Gerrit-HasComments: No