You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/15 15:21:21 UTC

[GitHub] [solr] madrob commented on pull request #18: SOLR-15261: SortedDocValues no longer extends BinaryDocValues

madrob commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799505762


   > I propose that you remove the comment "//TODO: SortedDocValues quick fix" everywhere that you put it. In two places, I suggested alternative comments scoped to the feature of a possible future optimization. In the other places, I think the ord to BytesRef resolution can't be delayed/avoided.
   
   I disagree with this. Maybe you're right, but we can leave the comment in until we've had more time to think this through.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org