You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Dante-dan (via GitHub)" <gi...@apache.org> on 2026/09/12 05:24:17 UTC
[PR] fix(desktop): add HTML artifact Finder fallback [maka]
Dante-dan opened a new pull request, #5218:
URL: https://github.com/apache/maka/pull/5218
## Summary
- Add the existing localized **Show in Finder** action to the HTML artifact read-failure banner while leaving successful sandboxed previews unchanged.
- Reuse the Artifact Pane's existing `openPath(sessionId, artifactId)` route, so materialization and path validation remain in the main process.
- Add a focused rendered-failure regression and strengthen the desktop service adapter assertion.
PR #5216 independently proposed wiring the same failure-state callback. This version keeps the issue's failure-only scope and adds regression coverage without changing successful HTML artifact opening.
Fixes #5215
## Verification
- Desktop workspace dependency build passed.
- Desktop `build:main`, typecheck, and renderer production build passed.
- 27 focused HTML fallback, adapter, artifact IPC, open-path guard, and external-link guard tests passed.
- Biome passed on all four changed files.
- `git diff --check origin/main...HEAD` passed.
- Independent acceptance reran the main-process TypeScript compile and three focused suites: 15 passed, 0 failed.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implemented and tested the focused UI fallback; a separate Codex acceptance pass reviewed the diff and reran targeted validation.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): add HTML artifact Finder fallback [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5218: fix(desktop): add HTML artifact Finder fallback
URL: https://github.com/apache/maka/pull/5218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): add HTML artifact Finder fallback [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5218:
URL: https://github.com/apache/maka/pull/5218#issuecomment-6307578785
<!-- maka-lifecycle:stale-close -->
This pull request has been closed because it received no new commits during the 7-day grace period. This is not a judgement on the merit of the change; it only keeps the review queue aligned with work that is actively in flight.
The branch and review history are preserved. Push a new commit and reopen the pull request whenever the work is ready to continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): add HTML artifact Finder fallback [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5218:
URL: https://github.com/apache/maka/pull/5218#issuecomment-6137963696
<!-- maka-lifecycle:stale-warning -->
This pull request has had no new commits for 30 days and has been marked stale. It will be closed in 7 days unless a new commit is pushed.
Comments do not reset this timer: only a new commit does. If the pull request is intentionally long-lived, a maintainer can apply the `pinned` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org