[GitHub] [pulsar] sijie commented on issue #4746: [go function] fix: go function should parse conf content first

[GitBox <gi...@apache.org>]

sijie commented on issue #4746: [go function] fix: go function should parse conf content first
URL: https://github.com/apache/pulsar/pull/4746#issuecomment-512621788
 
 
   @freeznet thank you for your clarification. It is a really great writeup! (love it) 
   
   back to the fix itself, I think a better fix here is the followings:
   
   - if confFilePath != "" and confContent != "", panic
   - if confFilePath != "", check if the file exists or not. If the file exists, read the file; if the file doesn't exists, and confContent == "", panic.
   - Then read confContent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services