[jira] [Updated] (YARN-5736) YARN container executor config does not handle white space

["Miklos Szegedi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Miklos Szegedi updated YARN-5736:
---------------------------------
    Attachment: YARN_5736.000.patch

I added a trim() function on both configuration keys and values. It removes all characters that satisfy isspace() from the beginning and the end of the strings. I also added error name 'unknown', if errno is not set to a valid error.

Tested manually.

> YARN container executor config does not handle white space
> ----------------------------------------------------------
>
>                 Key: YARN-5736
>                 URL: https://issues.apache.org/jira/browse/YARN-5736
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Trivial
>         Attachments: YARN_5736.000.patch
>
>
> The container executor configuration reader does not handle white spaces or malformed key value pairs in the config file correctly or gracefully
> as an example the following key value line which is part of the configuration (note the << is used as a marker to show the extra trailing space):
> yarn.nodemanager.linux-container-executor.group=yarn <<
> is a valid line but when you run the check over the file:
> [root@test]#./container-executor --checksetup
> Can't get group information for yarn - Success.
> [root@test]#
> It fails to find the yarn group but it really tries to find the "yarn " group which fails. There is no trimming anywhere while processing the lines. If a space would be added in before or after the = sign a failure would also occur.
> Minor nit is the fact that a failure still is logged as a Success



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org