You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/22 22:14:48 UTC
[GitHub] [superset] sonyasha opened a new issue #15312: Custom sequential color schemes can not be added
sonyasha opened a new issue #15312:
URL: https://github.com/apache/superset/issues/15312
### A clear and concise description of what the bug is.
When new sequential color scheme is added to the `EXTRA_SEQUENTIAL_COLOR_SCHEMES` variable in `config.py` it does not appear in the list of linear color schemes.
### Expected results
New sequential color scheme appears in the linear color schemes.
### Actual results
New sequential color scheme does not appear in the linear color schemes dropdown, instead it can be found in the list of categorical color schemes.
#### How to reproduce the bug
1. Add
```
EXTRA_SEQUENTIAL_COLOR_SCHEMES = [
{
"id": "GnYlRd",
"label": "green/yellow/red",
"colors": ['#006837','#1a9850','#66bd63','#a6d96a','#d9ef8b','#fee08b','#fdae61','#f46d43','#d73027','#a50026'],
"isDiverging": True,
"description": "",
}
]
```
to the `config.py` file
2. Once the `superset_app` container reloads, open any visualization that uses sequential schemes, e.g. Country of Citizenship from examples.
3. Click `COUNTRY COLOR SCHEME` dropdown and ensure that there is no green/yellow/red color scheme.
4. Open any visualization that uses categorical schemes, e.g. Age distribution of respondents from examples.
5. Click Customize tab and `COLOR SCHEME` dropdown, green/yellow/red scheme will be there.
### Environment
- superset version: `1.2.0rc2`
- python version: `3.7.9`
- node.js version: `14.15.5`
### Additional context
It should be a one line fix in `setupColors.ts`, new sequential color schemes are currently registered in `categoricalSchemeRegistry` instead of `sequentialSchemeRegistry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #15312: Custom sequential color schemes can not be added
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #15312:
URL: https://github.com/apache/superset/issues/15312#issuecomment-867296991
> Pushed a PR #15314
Thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sonyasha commented on issue #15312: Custom sequential color schemes can not be added
Posted by GitBox <gi...@apache.org>.
sonyasha commented on issue #15312:
URL: https://github.com/apache/superset/issues/15312#issuecomment-866448586
Pushed a PR https://github.com/apache/superset/pull/15314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sonyasha closed issue #15312: Custom sequential color schemes can not be added
Posted by GitBox <gi...@apache.org>.
sonyasha closed issue #15312:
URL: https://github.com/apache/superset/issues/15312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sonyasha commented on issue #15312: Custom sequential color schemes can not be added
Posted by GitBox <gi...@apache.org>.
sonyasha commented on issue #15312:
URL: https://github.com/apache/superset/issues/15312#issuecomment-870505153
The change has been merged, the issue can be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sonyasha closed issue #15312: Custom sequential color schemes can not be added
Posted by GitBox <gi...@apache.org>.
sonyasha closed issue #15312:
URL: https://github.com/apache/superset/issues/15312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sonyasha commented on issue #15312: Custom sequential color schemes can not be added
Posted by GitBox <gi...@apache.org>.
sonyasha commented on issue #15312:
URL: https://github.com/apache/superset/issues/15312#issuecomment-870505153
The change has been merged, the issue can be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org