You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by hu...@apache.org on 2014/01/25 10:52:17 UTC
[1/3] git commit: updated refs/heads/4.3-forward to c307de3
Updated Branches:
refs/heads/4.3-forward 81a83b5b3 -> c307de312
Backport findbugs configuration to 4.3 so we can run a findbugs report in jenkins.
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/c307de31
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/c307de31
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/c307de31
Branch: refs/heads/4.3-forward
Commit: c307de312dccb55cb4d57f0ebde7859606f983c0
Parents: 60ac127
Author: Hugo Trippaers <ht...@schubergphilis.com>
Authored: Sat Jan 25 10:51:10 2014 +0100
Committer: Hugo Trippaers <ht...@schubergphilis.com>
Committed: Sat Jan 25 10:52:09 2014 +0100
----------------------------------------------------------------------
pom.xml | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/c307de31/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 68d8dad..7af7139 100644
--- a/pom.xml
+++ b/pom.xml
@@ -87,6 +87,7 @@
<cs.daemon.version>1.0.10</cs.daemon.version>
<cs.jna.version>4.0.0</cs.jna.version>
<cs.checkstyle.version>2.10</cs.checkstyle.version>
+ <cs.findbugs.version>2.5.3</cs.findbugs.version>
</properties>
<distributionManagement>
@@ -444,6 +445,21 @@
</testResources>
<outputDirectory>${basedir}/${cs.target.dir}/classes</outputDirectory>
<testOutputDirectory>${basedir}/${cs.target.dir}/test-classes</testOutputDirectory>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>cloudstack-findbugs</id>
+ <phase>none</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
<pluginManagement>
<plugins>
<plugin>
@@ -712,6 +728,25 @@
</formats>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <version>${cs.findbugs.version}</version>
+ <configuration>
+ <effort>Max</effort>
+ <threshold>High</threshold>
+ <xmlOutput>true</xmlOutput>
+ <failOnError>false</failOnError>
+ </configuration>
+ <executions>
+ <execution>
+ <id>cloudstack-findbugs</id>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</pluginManagement>
</build>
@@ -771,5 +806,23 @@
<module>vmware-base</module>
</modules>
</profile>
+ <profile>
+ <id>enablefindbugs</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>cloudstack-findbugs</id>
+ <phase>process-classes</phase>
+ <inherited>true</inherited>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
</profiles>
</project>
[2/3] git commit: updated refs/heads/4.3-forward to c307de3
Posted by hu...@apache.org.
Backport fixed for issues found by Findbugs
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/60ac1278
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/60ac1278
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/60ac1278
Branch: refs/heads/4.3-forward
Commit: 60ac12780bfa1604902a89d5dc7937a8b9334e0d
Parents: f18c5a1
Author: Hugo Trippaers <ht...@schubergphilis.com>
Authored: Fri Jan 24 13:01:08 2014 +0000
Committer: Hugo Trippaers <ht...@schubergphilis.com>
Committed: Sat Jan 25 10:52:09 2014 +0100
----------------------------------------------------------------------
.../cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java | 2 +-
.../com/cloud/hypervisor/vmware/resource/VmwareResource.java | 2 +-
.../cloudstack/storage/motion/VmwareStorageMotionStrategy.java | 2 +-
.../com/cloud/hypervisor/xen/resource/CitrixResourceBase.java | 4 ++--
.../storage/motion/XenServerStorageMotionStrategy.java | 2 +-
utils/src/com/cloud/utils/net/NetUtils.java | 2 +-
.../src/com/cloud/hypervisor/vmware/mo/DatastoreMO.java | 6 ++++++
7 files changed, 13 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
index 012c8a5..bdccc10 100644
--- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
+++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
@@ -960,7 +960,7 @@ public class LibvirtStorageAdaptor implements StorageAdaptor {
}
if (disk == null) {
- throw new CloudRuntimeException("Failed to create " + disk.getPath() + " from template " + template.getName());
+ throw new CloudRuntimeException("Failed to create disk from template " + template.getName());
}
return disk;
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index 1d4c43f..bfb95fd 100755
--- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -3508,7 +3508,7 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa
public int compare(DiskTO arg0, DiskTO arg1) {
if (arg0.getDiskSeq() < arg1.getDiskSeq()) {
return -1;
- } else if (arg0.getDiskSeq() == arg1.getDiskSeq()) {
+ } else if (arg0.getDiskSeq().equals(arg1.getDiskSeq())) {
return 0;
}
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java b/plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
index 4668f67..446093f 100644
--- a/plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
+++ b/plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
@@ -95,7 +95,7 @@ public class VmwareStorageMotionStrategy implements DataMotionStrategy {
try {
VMInstanceVO instance = instanceDao.findById(vmTo.getId());
if (instance != null) {
- if (srcHost.getClusterId() == destHost.getClusterId()) {
+ if (srcHost.getClusterId().equals(destHost.getClusterId())) {
answer = migrateVmWithVolumesWithinCluster(instance, vmTo, srcHost, destHost, volumeMap);
} else {
answer = migrateVmWithVolumesAcrossCluster(instance, vmTo, srcHost, destHost, volumeMap);
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
index 16fef1d..f065d58 100644
--- a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
+++ b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
@@ -846,7 +846,7 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
Set<VIF> dom0Vifs = dom0.getVIFs(conn);
for (VIF vif:dom0Vifs) {
vif.getRecord(conn);
- if (vif.getNetwork(conn).getUuid(conn) == nw.getUuid(conn)) {
+ if (vif.getNetwork(conn).getUuid(conn).equals(nw.getUuid(conn))) {
dom0vif = vif;
s_logger.debug("A VIF for dom0 has already been found - No need to create one");
}
@@ -3427,7 +3427,7 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
Set<VBD> vbds = vm.getVBDs(conn);
for( VBD vbd : vbds) {
VBD.Record vbdRec = vbd.getRecord(conn);
- if( vbdRec.type.equals(Types.VbdType.CD.toString()) && !vbdRec.empty ) {
+ if( vbdRec.type.equals(Types.VbdType.CD) && !vbdRec.empty ) {
vbd.eject(conn);
break;
}
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java b/plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
index 3dc7dd8..8d11940 100644
--- a/plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
+++ b/plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
@@ -103,7 +103,7 @@ public class XenServerStorageMotionStrategy implements DataMotionStrategy {
try {
VMInstanceVO instance = instanceDao.findById(vmTo.getId());
if (instance != null) {
- if (srcHost.getClusterId() == destHost.getClusterId()) {
+ if (srcHost.getClusterId().equals(destHost.getClusterId())) {
answer = migrateVmWithVolumesWithinCluster(instance, vmTo, srcHost, destHost, volumeMap);
} else {
answer = migrateVmWithVolumesAcrossCluster(instance, vmTo, srcHost, destHost, volumeMap);
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/utils/src/com/cloud/utils/net/NetUtils.java
----------------------------------------------------------------------
diff --git a/utils/src/com/cloud/utils/net/NetUtils.java b/utils/src/com/cloud/utils/net/NetUtils.java
index a72aded..792d606 100755
--- a/utils/src/com/cloud/utils/net/NetUtils.java
+++ b/utils/src/com/cloud/utils/net/NetUtils.java
@@ -840,7 +840,7 @@ public class NetUtils {
//this implies cidrA is super set of cidrB
return supersetOrSubset.isSuperset;
}
- else if (cidrALong[1] == cidrBLong[1]) {
+ else if (cidrALong[1].equals(cidrBLong[1])) {
//this implies both the cidrs are equal
return supersetOrSubset.sameSubnet;
}
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/60ac1278/vmware-base/src/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
----------------------------------------------------------------------
diff --git a/vmware-base/src/com/cloud/hypervisor/vmware/mo/DatastoreMO.java b/vmware-base/src/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
index 4b2ce08..716bc20 100755
--- a/vmware-base/src/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
+++ b/vmware-base/src/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
@@ -32,6 +32,7 @@ import com.vmware.vim25.PropertySpec;
import com.vmware.vim25.SelectionSpec;
import com.vmware.vim25.TraversalSpec;
+import com.cloud.exception.CloudException;
import com.cloud.hypervisor.vmware.util.VmwareContext;
import com.cloud.utils.Pair;
@@ -349,7 +350,12 @@ public class DatastoreMO extends BaseMO {
ArrayList<HostDatastoreBrowserSearchResults> results = browserMo.searchDatastoreSubFolders("[" + getName() + "]", fileName, caseInsensitive);
if (results != null && results.size() > 1) {
s_logger.warn("Multiple files with name " + fileName + " exists in datastore " + datastorePath + ". Trying to choose first file found in search attempt.");
+ } else if (results == null) {
+ String msg = "No file found with name " + fileName + " found in datastore " + datastorePath;
+ s_logger.error(msg);
+ throw new CloudException(msg);
}
+
for (HostDatastoreBrowserSearchResults result : results) {
List<FileInfo> info = result.getFile();
if (info != null && info.size() > 0) {
[3/3] git commit: updated refs/heads/4.3-forward to c307de3
Posted by hu...@apache.org.
Findbugs finding : Incorrect use of equality
(cherry picked from commit 10cc5645e8b9713bc7c86d543413d396ce203cc6)
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f18c5a19
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f18c5a19
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f18c5a19
Branch: refs/heads/4.3-forward
Commit: f18c5a1910b6370585a1d61638b8310c3ecba5ef
Parents: 81a83b5
Author: Hugo Trippaers <ht...@schubergphilis.com>
Authored: Fri Jan 24 11:58:53 2014 +0000
Committer: Hugo Trippaers <ht...@schubergphilis.com>
Committed: Sat Jan 25 10:52:09 2014 +0100
----------------------------------------------------------------------
.../src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f18c5a19/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
index 89bbeb9..54e9815 100755
--- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
+++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
@@ -168,7 +168,7 @@ public class VmwareServerDiscoverer extends DiscovererBase implements
_clusterDetailsDao.persist(clusterId, clusterDetails);
}
String updatedInventoryPath = validateCluster(url, vmwareDc);
- if (url.getPath() != updatedInventoryPath) {
+ if (!url.getPath().equals(updatedInventoryPath)) {
// If url from API doesn't specify DC then update url in database with DC associated with this zone.
clusterDetails.put("url", url.getScheme() + "://" + url.getHost() + updatedInventoryPath);
_clusterDetailsDao.persist(clusterId, clusterDetails);